From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Maxim Levitsky <mlevitsk@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 3/4] device-core: use atomic_set on .realized property
Date: Mon, 4 May 2020 13:22:26 +0200 [thread overview]
Message-ID: <b265d4ee-400e-bb80-cc37-e89c5dab2a8c@redhat.com> (raw)
In-Reply-To: <20200504104538.GC354891@stefanha-x1.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]
On 04/05/20 12:45, Stefan Hajnoczi wrote:
>> @@ -983,7 +983,7 @@ static void device_set_realized(Object *obj, bool value, Error **errp)
>> }
>>
>> assert(local_err == NULL);
>> - dev->realized = value;
>> + atomic_set(&dev->realized, value);
> A memory barrier is probably needed so that the atomic_read() thread
> sees up-to-date dev fields.
Yes, it should be a store-release for the false->true case. The
true->false case probably doesn't matter as much.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-04 11:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 20:36 [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread Maxim Levitsky
2020-04-16 20:36 ` [PATCH 1/4] scsi/scsi_bus: switch search direction in scsi_device_find Maxim Levitsky
2020-04-16 20:36 ` [PATCH 2/4] device-core: use RCU for list of childs of a bus Maxim Levitsky
2020-05-04 10:41 ` Stefan Hajnoczi
2020-05-11 8:48 ` Maxim Levitsky
2020-04-16 20:36 ` [PATCH 3/4] device-core: use atomic_set on .realized property Maxim Levitsky
2020-05-04 10:45 ` Stefan Hajnoczi
2020-05-04 11:22 ` Paolo Bonzini [this message]
2020-05-04 11:36 ` Maxim Levitsky
2020-05-11 11:00 ` Maxim Levitsky
2020-05-11 11:11 ` Paolo Bonzini
2020-05-11 11:14 ` Maxim Levitsky
2020-04-16 20:36 ` [PATCH 4/4] virtio-scsi: don't touch scsi devices that are not yet realized Maxim Levitsky
2020-05-04 11:24 ` Paolo Bonzini
2020-05-11 11:21 ` Maxim Levitsky
2020-04-16 21:33 ` [PATCH 0/4] RFC/WIP: Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread no-reply
2020-04-16 21:35 ` no-reply
2020-04-16 21:47 ` no-reply
2020-05-04 10:59 ` Stefan Hajnoczi
2020-05-04 11:38 ` Paolo Bonzini
2020-05-04 11:43 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b265d4ee-400e-bb80-cc37-e89c5dab2a8c@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=mlevitsk@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).