From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB21CC04EBF for ; Mon, 23 Sep 2019 11:53:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C34F207FD for ; Mon, 23 Sep 2019 11:53:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C34F207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCMu2-0001NR-MU for qemu-devel@archiver.kernel.org; Mon, 23 Sep 2019 07:53:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44525) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCMtD-0000XG-8i for qemu-devel@nongnu.org; Mon, 23 Sep 2019 07:52:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCMtC-00019J-1b for qemu-devel@nongnu.org; Mon, 23 Sep 2019 07:52:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35288) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCMtB-000188-PN for qemu-devel@nongnu.org; Mon, 23 Sep 2019 07:52:21 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D9AEE4FCDA for ; Mon, 23 Sep 2019 11:52:20 +0000 (UTC) Received: by mail-wm1-f72.google.com with SMTP id 190so6541416wme.4 for ; Mon, 23 Sep 2019 04:52:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sSRUGmpkqjCBncYBiL2Nf0gUwX95C0t8AFl/cfVvkgc=; b=fSGBL4jGJL2DUJgO12agmEX7l0QGSgtj2i3dXGqdcW8FPFnM/FtqaXfICefPaL/86M XtG+R3hULUwORptGp98wVmUzUJ41E40G1u6BjLMeKOYGz60v1tALKxBHbHdlrgXo4qUK QP9CecegLl/08BaIKaxNHqZ725R2OQyEs6h3Yuy28ojFNGAbvonQLYNJyZ6W/Lrwv80f aGFCqGbq/4hQ1BIJUU28Twm+qTYleCMxugnQ3B7377Y74pm+oYR42JXINt8R17pq0Rz6 ydiPlDx0H6lvxk63uOMnZAlOigywUPLCpIXQA+BzlHATJsf77Ak0oB2QSBqdTE1iuZYU v7Gg== X-Gm-Message-State: APjAAAUjGl5HX+0YRmKWEtKCZVT35zEJDWZvIgdIn2LAXoViNNr2bSnG tV7EmCThDkvC0+EqadVbvL39wsiaSq3fU27nxCRmY7yWh4cSHqrBSzK8BMtTkLLe+MT1V02tc/k eiprQYSzLfLw8raw= X-Received: by 2002:adf:f8cf:: with SMTP id f15mr21258216wrq.292.1569239538889; Mon, 23 Sep 2019 04:52:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9URtIpl/Xb7uAwk1Pp2XHBPPCvdkeV0d48XhCw7VjILVie61W4q4nQ8/gFlaV0Zc3TWE66Q== X-Received: by 2002:adf:f8cf:: with SMTP id f15mr21258202wrq.292.1569239538623; Mon, 23 Sep 2019 04:52:18 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9520:22e6:6416:5c36? ([2001:b07:6468:f312:9520:22e6:6416:5c36]) by smtp.gmail.com with ESMTPSA id c6sm11827477wrb.60.2019.09.23.04.52.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 04:52:17 -0700 (PDT) Subject: Re: [Qemu-devel] [PATCH] Replace '-machine accel=xyz' with '-accel xyz' To: Markus Armbruster References: <20190904052739.22123-1-thuth@redhat.com> <5e8d67e5-842f-7cea-28a5-f07050615c38@redhat.com> <87wodzp7vm.fsf@dusky.pond.sub.org> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: Date: Mon, 23 Sep 2019 13:52:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87wodzp7vm.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Thomas Huth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23/09/19 13:30, Markus Armbruster wrote: > -accel is yet another convenience option. We have so many of them. I > dislike the complexity they add to the CLI. Here's how this one got in= : >=20 > commit 8d4e9146b3568022ea5730d92841345d41275d66 > Author: KONRAD Frederic > Date: Thu Feb 23 18:29:08 2017 +0000 >=20 > tcg: add options for enabling MTTCG > =20 > We know there will be cases where MTTCG won't work until additional= work > is done in the front/back ends to support. It will however be usefu= l to > be able to turn it on. > =20 > As a result MTTCG will default to off unless the combination is > supported. However the user can turn it on for the sake of testing. > =20 > Signed-off-by: KONRAD Frederic > [AJB: move to -accel tcg,thread=3Dmulti|single, defaults] > Signed-off-by: Alex Benn=C3=A9e > Reviewed-by: Richard Henderson >=20 > Not a peep on why the existing options are so insufficient we must have > another one. >=20 > Our CLI will remain the steaming mess it has become until we reform the > habits that got us there. -accel's accel suboption is currently defined as a convenience option, but it shouldn't be. It's the older "-M accel=3Dfoo:bar" that should become "-accel foo -accel bar" and -accel then is the preferred way. The existing option "-M accel" was insufficient because it didn't allow accelerator-specific suboptions; they were all over the place ("-machine kernel_irqchip", "-tb-size", etc.) and indeed mostly in wrong places. Paolo