From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
John Snow <jsnow@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Juan Quintela <quintela@redhat.com>, Fam Zheng <fam@euphon.net>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] block/dirty-bitmaps: add block_dirty_bitmap_check function
Date: Mon, 25 Feb 2019 09:07:23 -0600 [thread overview]
Message-ID: <b293f181-7b78-c11b-81ab-0f4b04e6fb25@redhat.com> (raw)
In-Reply-To: <f8cee179-d67f-2426-7d65-c208a82f1876@virtuozzo.com>
On 2/25/19 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
>
> And one more important question: we now creating new qapi bitmap status, consisting of several bool fields.
> Shouldn't we instead implement it as an array of flags?
Parsing:
{ "busy": false, "persistent": false, "recording": true }
is easier than parsing:
{ "flags": [ "recording" ] }
(and knowing that unlisted flags "busy", "persistent", and
"inconsistent" are false), or:
{ "flags": [ { "busy": false }, { "persistent": false }, { "recording":
true } ] }
So without more reason why an array of flags would be needed, I don't
see the point for it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-02-25 15:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 0:22 [Qemu-devel] [PATCH v2 0/4] bitmaps: add inconsistent bit John Snow
2019-02-23 0:22 ` [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: " John Snow
2019-02-25 13:47 ` Eric Blake
2019-02-25 14:18 ` Vladimir Sementsov-Ogievskiy
2019-02-25 15:30 ` Vladimir Sementsov-Ogievskiy
2019-02-27 18:45 ` John Snow
2019-02-28 10:13 ` Vladimir Sementsov-Ogievskiy
2019-02-28 13:44 ` Eric Blake
2019-02-28 14:01 ` Vladimir Sementsov-Ogievskiy
2019-02-25 18:32 ` John Snow
2019-02-25 15:51 ` [Qemu-devel] [PATCH] dirty-bitmap: introduce inconsistent bitmaps Vladimir Sementsov-Ogievskiy
2019-02-23 0:22 ` [Qemu-devel] [PATCH v2 2/4] block/dirty-bitmap: add inconsistent status John Snow
2019-02-25 15:12 ` Eric Blake
2019-02-23 0:22 ` [Qemu-devel] [PATCH v2 3/4] block/dirty-bitmaps: add block_dirty_bitmap_check function John Snow
2019-02-25 13:37 ` Vladimir Sementsov-Ogievskiy
2019-02-25 14:59 ` Vladimir Sementsov-Ogievskiy
2019-02-25 15:07 ` Eric Blake [this message]
2019-02-25 15:11 ` Vladimir Sementsov-Ogievskiy
2019-02-25 21:22 ` John Snow
2019-02-23 0:22 ` [Qemu-devel] [PATCH v2 4/4] block/dirty-bitmaps: implement inconsistent bit John Snow
2019-02-25 16:21 ` Vladimir Sementsov-Ogievskiy
2019-02-27 23:48 ` John Snow
2019-02-28 10:21 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b293f181-7b78-c11b-81ab-0f4b04e6fb25@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).