From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: AlexChen <alex.chen@huawei.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>, QEMU <qemu-devel@nongnu.org>,
zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH V2] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference
Date: Mon, 2 Nov 2020 10:16:52 +0100 [thread overview]
Message-ID: <b2945df0-186e-e670-bdfc-34104d8ddf2c@redhat.com> (raw)
In-Reply-To: <5F9F8D88.9030102@huawei.com>
On 11/2/20 5:39 AM, AlexChen wrote:
> In exynos4210_fimd_update(), the pointer s is dereferinced before
Typo dereferinced -> dereferenced.
> being check if it is valid, which may lead to NULL pointer dereference.
> So move the assignment to global_width after checking that the s is valid.
Easier to read "after checking 's' is valid."
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Alex Chen <alex.chen@huawei.com>
> ---
> hw/display/exynos4210_fimd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-11-02 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 4:39 [PATCH V2] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference AlexChen
2020-11-02 9:16 ` Philippe Mathieu-Daudé [this message]
2020-11-02 10:10 ` AlexChen
2020-11-02 10:13 ` [PATCH V3] " AlexChen
2020-11-02 12:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2945df0-186e-e670-bdfc-34104d8ddf2c@redhat.com \
--to=philmd@redhat.com \
--cc=alex.chen@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).