* [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option
@ 2018-08-15 17:57 prasad.singamsetty
2018-08-15 18:58 ` Mark Kanda
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: prasad.singamsetty @ 2018-08-15 17:57 UTC (permalink / raw)
To: qemu-devel, pbonzini; +Cc: konrad.wilk, mark.kanda, Prasad Singamsetty
From: Prasad Singamsetty <prasad.singamsetty@oracle.com>
qemu command fails to process -overcommit option. Add the missing
call to qemu_add_opts() in vl.c.
Signed-off-by: Prasad Singamsetty <prasad.singamsetty@oracle.com>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 16b913f9d5..12d27fa028 100644
--- a/vl.c
+++ b/vl.c
@@ -2987,6 +2987,7 @@ int main(int argc, char **argv, char **envp)
qemu_add_opts(&qemu_object_opts);
qemu_add_opts(&qemu_tpmdev_opts);
qemu_add_opts(&qemu_realtime_opts);
+ qemu_add_opts(&qemu_overcommit_opts);
qemu_add_opts(&qemu_msg_opts);
qemu_add_opts(&qemu_name_opts);
qemu_add_opts(&qemu_numa_opts);
--
2.14.0-rc1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option
2018-08-15 17:57 [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option prasad.singamsetty
@ 2018-08-15 18:58 ` Mark Kanda
2018-08-17 17:39 ` Paolo Bonzini
2018-09-03 4:35 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Mark Kanda @ 2018-08-15 18:58 UTC (permalink / raw)
To: prasad.singamsetty, qemu-devel, pbonzini; +Cc: konrad.wilk
On 8/15/2018 12:57 PM, prasad.singamsetty@oracle.com wrote:
> From: Prasad Singamsetty <prasad.singamsetty@oracle.com>
>
> qemu command fails to process -overcommit option. Add the missing
> call to qemu_add_opts() in vl.c.
>
> Signed-off-by: Prasad Singamsetty <prasad.singamsetty@oracle.com>
Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 16b913f9d5..12d27fa028 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2987,6 +2987,7 @@ int main(int argc, char **argv, char **envp)
> qemu_add_opts(&qemu_object_opts);
> qemu_add_opts(&qemu_tpmdev_opts);
> qemu_add_opts(&qemu_realtime_opts);
> + qemu_add_opts(&qemu_overcommit_opts);
> qemu_add_opts(&qemu_msg_opts);
> qemu_add_opts(&qemu_name_opts);
> qemu_add_opts(&qemu_numa_opts);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option
2018-08-15 17:57 [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option prasad.singamsetty
2018-08-15 18:58 ` Mark Kanda
@ 2018-08-17 17:39 ` Paolo Bonzini
2018-09-03 4:35 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2018-08-17 17:39 UTC (permalink / raw)
To: prasad.singamsetty, qemu-devel; +Cc: konrad.wilk, mark.kanda
On 15/08/2018 19:57, prasad.singamsetty@oracle.com wrote:
> From: Prasad Singamsetty <prasad.singamsetty@oracle.com>
>
> qemu command fails to process -overcommit option. Add the missing
> call to qemu_add_opts() in vl.c.
>
> Signed-off-by: Prasad Singamsetty <prasad.singamsetty@oracle.com>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 16b913f9d5..12d27fa028 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2987,6 +2987,7 @@ int main(int argc, char **argv, char **envp)
> qemu_add_opts(&qemu_object_opts);
> qemu_add_opts(&qemu_tpmdev_opts);
> qemu_add_opts(&qemu_realtime_opts);
> + qemu_add_opts(&qemu_overcommit_opts);
> qemu_add_opts(&qemu_msg_opts);
> qemu_add_opts(&qemu_name_opts);
> qemu_add_opts(&qemu_numa_opts);
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option
2018-08-15 17:57 [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option prasad.singamsetty
2018-08-15 18:58 ` Mark Kanda
2018-08-17 17:39 ` Paolo Bonzini
@ 2018-09-03 4:35 ` Thomas Huth
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2018-09-03 4:35 UTC (permalink / raw)
To: prasad.singamsetty, qemu-devel, pbonzini, qemu-stable; +Cc: konrad.wilk
On 2018-08-15 19:57, prasad.singamsetty@oracle.com wrote:
> From: Prasad Singamsetty <prasad.singamsetty@oracle.com>
>
> qemu command fails to process -overcommit option. Add the missing
> call to qemu_add_opts() in vl.c.
>
> Signed-off-by: Prasad Singamsetty <prasad.singamsetty@oracle.com>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 16b913f9d5..12d27fa028 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2987,6 +2987,7 @@ int main(int argc, char **argv, char **envp)
> qemu_add_opts(&qemu_object_opts);
> qemu_add_opts(&qemu_tpmdev_opts);
> qemu_add_opts(&qemu_realtime_opts);
> + qemu_add_opts(&qemu_overcommit_opts);
> qemu_add_opts(&qemu_msg_opts);
> qemu_add_opts(&qemu_name_opts);
> qemu_add_opts(&qemu_numa_opts);
>
I think this should go into the stable release as well.
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-03 4:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-15 17:57 [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option prasad.singamsetty
2018-08-15 18:58 ` Mark Kanda
2018-08-17 17:39 ` Paolo Bonzini
2018-09-03 4:35 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).