From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1fwgan-0002cx-Qt
	for qemu-devel@nongnu.org; Mon, 03 Sep 2018 00:36:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1fwgak-0001uF-KV
	for qemu-devel@nongnu.org; Mon, 03 Sep 2018 00:36:01 -0400
References: <20180815175704.105902-1-prasad.singamsetty@oracle.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <b298b247-42f4-f096-e60a-cccfcfc9d1cd@redhat.com>
Date: Mon, 3 Sep 2018 06:35:53 +0200
MIME-Version: 1.0
In-Reply-To: <20180815175704.105902-1-prasad.singamsetty@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for
 -overcommit option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: prasad.singamsetty@oracle.com, qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-stable@nongnu.org
Cc: konrad.wilk@oracle.com

On 2018-08-15 19:57, prasad.singamsetty@oracle.com wrote:
> From: Prasad Singamsetty <prasad.singamsetty@oracle.com>
> 
> qemu command fails to process -overcommit option. Add the missing
> call to qemu_add_opts() in vl.c.
> 
> Signed-off-by: Prasad Singamsetty <prasad.singamsetty@oracle.com>
> ---
>  vl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/vl.c b/vl.c
> index 16b913f9d5..12d27fa028 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2987,6 +2987,7 @@ int main(int argc, char **argv, char **envp)
>      qemu_add_opts(&qemu_object_opts);
>      qemu_add_opts(&qemu_tpmdev_opts);
>      qemu_add_opts(&qemu_realtime_opts);
> +    qemu_add_opts(&qemu_overcommit_opts);
>      qemu_add_opts(&qemu_msg_opts);
>      qemu_add_opts(&qemu_name_opts);
>      qemu_add_opts(&qemu_numa_opts);
> 

I think this should go into the stable release as well.

 Thomas