From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches
Date: Sun, 9 May 2021 18:05:37 +0200 [thread overview]
Message-ID: <b2a28a69-2525-b07e-bec8-65d7439f1154@redhat.com> (raw)
In-Reply-To: <d5bf0064-052e-a0c7-cc17-72db815949e2@redhat.com>
On 07/05/2021 14.41, Paolo Bonzini wrote:
> On 07/05/21 11:45, Thomas Huth wrote:
>>
>>
>> diff --git a/Makefile b/Makefile
>> index bcbbec71a1..3088502329 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -85,7 +85,8 @@ x := $(shell rm -rf meson-private meson-info meson-logs)
>> endif
>>
>> # 1. ensure config-host.mak is up-to-date
>> -config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios
>> $(SRC_PATH)/VERSION
>> +config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios
>> $(SRC_PATH)/VERSION \
>> + $(SRC_PATH)/default-configs/targets
>> @echo config-host.mak is out-of-date, running configure
>> @if test -f meson-private/coredata.dat; then \
>> ./config.status --skip-meson; \
>>
>> I.e. re-run configure if somethings in default-configs/targets changed.
>> Does that look sane?
>
> I am not sure if using a directory is reliable (it's pre-existing for
> pc-bios). However you probably can use
>
> # currently in tests/Makefile.include, move it to toplevel Makefile
> TARGETS=$(patsubst libqemu-%.fa, %, $(filter libqemu-%.fa, $(ninja-targets)))
> config-host.mak: $(SRC_PATH)/configure $(TARGETS:%=default-configs/targets/%)
>
> And then if a file goes missing it will trigger the rebuild of config-host.mak.
Sounds like an idea, too ... but I'm unsure whether it's doable due to the
order of the statements there... TARGETS gets populated from ninja-targets,
but ninja-targets gets set *after* the config-host.mak block ... would it be
safe to move the config-host.mak block around?
Thomas
next prev parent reply other threads:[~2021-05-09 16:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 10:44 [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches Thomas Huth
2021-05-03 10:44 ` [PULL 01/10] Remove the deprecated moxie target Thomas Huth
2021-05-03 10:44 ` [PULL 02/10] tests/docker/dockerfiles: Add ccache to containers where it was missing Thomas Huth
2021-05-03 10:44 ` [PULL 03/10] include/sysemu: Poison all accelerator CONFIG switches in common code Thomas Huth
2021-05-03 10:44 ` [PULL 04/10] gitlab-ci: Replace YAML anchors by extends (container_job) Thomas Huth
2021-05-03 10:44 ` [PULL 05/10] gitlab-ci: Replace YAML anchors by extends (native_build_job) Thomas Huth
2021-05-03 10:44 ` [PULL 06/10] gitlab-ci: Replace YAML anchors by extends (native_test_job) Thomas Huth
2021-05-03 10:44 ` [PULL 07/10] libqos/qgraph: fix "UNAVAILBLE" typo Thomas Huth
2021-05-03 10:44 ` [PULL 08/10] docs/devel/qgraph: add troubleshooting information Thomas Huth
2021-05-03 10:44 ` [PULL 09/10] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm Thomas Huth
2021-05-03 10:44 ` [PULL 10/10] util/compatfd.c: Replaced a malloc call with g_malloc Thomas Huth
2021-05-05 18:06 ` [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches Peter Maydell
2021-05-06 7:00 ` Thomas Huth
2021-05-06 7:38 ` Peter Maydell
2021-05-07 9:45 ` Thomas Huth
2021-05-07 12:41 ` Paolo Bonzini
2021-05-09 16:05 ` Thomas Huth [this message]
2021-05-14 10:22 ` Philippe Mathieu-Daudé
2021-05-14 10:25 ` Thomas Huth
2021-05-20 2:40 ` Philippe Mathieu-Daudé
2021-05-20 5:08 ` Thomas Huth
2021-05-20 7:43 ` Paolo Bonzini
2021-05-20 13:06 ` Philippe Mathieu-Daudé
2021-05-20 13:10 ` Peter Maydell
2021-05-07 12:53 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a28a69-2525-b07e-bec8-65d7439f1154@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).