From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Ilya Leoshkevich <iii@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
qemu-s390x@nongnu.org
Subject: Re: [PATCH] target/s390x: Fix a typo in s390_cpu_class_init()
Date: Mon, 24 Mar 2025 07:05:05 +0100 [thread overview]
Message-ID: <b2a99dd6-3d19-46b1-9ef6-ee799ac7e021@redhat.com> (raw)
In-Reply-To: <20250323153018.73491-1-philmd@linaro.org>
On 23/03/2025 16.30, Philippe Mathieu-Daudé wrote:
> Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU subclasses")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/s390x/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
> index d73142600bf..1f75629ddc2 100644
> --- a/target/s390x/cpu.c
> +++ b/target/s390x/cpu.c
> @@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)
> resettable_class_set_parent_phases(rc, NULL, s390_cpu_reset_hold, NULL,
> &scc->parent_phases);
>
> - cc->class_by_name = s390_cpu_class_by_name,
> + cc->class_by_name = s390_cpu_class_by_name;
Please add a proper patch description next time. I spent dozens of seconds
to spot the typo in one of the words 'til I realized that it is the comma at
the end ;-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-03-24 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 15:30 [PATCH] target/s390x: Fix a typo in s390_cpu_class_init() Philippe Mathieu-Daudé
2025-03-23 19:20 ` Richard Henderson
2025-03-24 6:05 ` Thomas Huth [this message]
2025-03-24 16:33 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a99dd6-3d19-46b1-9ef6-ee799ac7e021@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).