From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LA51D-0004wc-Ai for qemu-devel@nongnu.org; Tue, 09 Dec 2008 11:01:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LA51B-0004vR-La for qemu-devel@nongnu.org; Tue, 09 Dec 2008 11:01:02 -0500 Received: from [199.232.76.173] (port=60714 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LA51B-0004vO-GI for qemu-devel@nongnu.org; Tue, 09 Dec 2008 11:01:01 -0500 Received: from mail-gx0-f17.google.com ([209.85.217.17]:42745) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LA51A-0002C6-Rk for qemu-devel@nongnu.org; Tue, 09 Dec 2008 11:01:01 -0500 Received: by gxk10 with SMTP id 10so22773gxk.10 for ; Tue, 09 Dec 2008 08:01:00 -0800 (PST) Message-ID: Date: Tue, 9 Dec 2008 16:58:36 +0100 From: Gildas Subject: Re: [Qemu-devel] [PATCH] rename vlan to vnet and mark vlan as deprecated In-Reply-To: <493E92DA.2030209@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081209153727.GT15102@redhat.com> <493E92DA.2030209@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org 2008/12/9 Anthony Liguori : > Daniel P. Berrange wrote: >> >> On Tue, Dec 09, 2008 at 04:01:53PM +0100, Gildas wrote: >> >>> >>> -- >>> This patch renames occurences of vlan/VLAN that are not related to IEE >>> 802.1q vlans to vnet/VNET respectively. >>> >>> Usage of vlan= in the -net options is still allowed but will produce >>> an error message on stderr indicating that the option is now >>> deprecated and will be removed in the future. >>> >> >> This bit will just piss people off. By all means change t to allow >> the net vnet= option, but printing out a warning for vlan= on every >> boot is just going to annoy people and they cannot simply change >> their scripts because they may well need to run with old QEMU and >> new QEMU >> > > Introducing an alias for something as core as vlan support is not all that > useful. We're never going to implement the vlan option. > > All of the internal references are for vlan too. > > Regards, > > Anthony Liguori I think that keeping backward compatibility is a good idea and I'm ok to remove the warning message even though I don't think it does any harm. I will modify the patch to document the fact that vlan= is not IEEE 902.1q and that vnet= is the prefered option. I really think that it's a change that should done, both in the code and usage as both will greatly benefit from a move to VNET. Just look at the actual naming mess in e1000.c where real 802.1q handling takes place as well... Regards, Gildas