From: Gildas <gildas.ml@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] rename vlan to vnet and mark vlan as deprecated
Date: Tue, 9 Dec 2008 17:30:40 +0100 [thread overview]
Message-ID: <b2ace7f20812090830n5ad9f76cy9a46b572f36ef403@mail.gmail.com> (raw)
In-Reply-To: <493E9769.7030701@codemonkey.ws>
>> I think that keeping backward compatibility is a good idea and I'm ok
>> to remove the warning message even though I don't think it does any
>> harm. I will modify the patch to document the fact that vlan= is not
>> IEEE 902.1q and that vnet= is the prefered option.
>>
>
> If we're going to switch to vnet= (and I don't think we should), then it
> should be with a flag day. And all at once conversion that changes internal
> and external references.
I'm not sure I understand what you mean by that
>> I really think that it's a change that should done, both in the code
>> and usage as both will greatly benefit from a move to VNET. Just look
>> at the actual naming mess in e1000.c where real 802.1q handling takes
>> place as well...
>>
>
> I think this may cause minor confusion for a very small number of people,
> but for most people, who probably have no idea what 802.1q is, it never is
> an issue.
>
> This is only the second time I've seen someone get confused by vlan= since
> the syntax was introduced. It's really not a big deal AFAICT.
>
> Regards,
>
> Anthony Liguori
As I see it, people who have no idea what 802.1q vlans are are not
sysadmins and will probably never use the vlan= option...
I'm confused about the reasons why an improvement for end users, be it
minor, should be rejected.
Regards.
Gildas
next prev parent reply other threads:[~2008-12-09 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 15:01 [Qemu-devel] [PATCH] rename vlan to vnet and mark vlan as deprecated Gildas
2008-12-09 15:29 ` Anthony Liguori
2008-12-09 17:20 ` Kristoffer Ericson
2008-12-09 16:40 ` Anthony Liguori
2008-12-09 16:51 ` Daniel P. Berrange
2008-12-09 17:14 ` Paul Brook
2008-12-09 15:37 ` Daniel P. Berrange
2008-12-09 15:46 ` Anthony Liguori
2008-12-09 15:58 ` Gildas
2008-12-09 16:06 ` Anthony Liguori
2008-12-09 16:30 ` Gildas [this message]
2008-12-09 21:36 ` Luca Bigliardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2ace7f20812090830n5ad9f76cy9a46b572f36ef403@mail.gmail.com \
--to=gildas.ml@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).