From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvpvR-0004Qc-Ai for qemu-devel@nongnu.org; Mon, 18 Feb 2019 15:54:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvpvQ-0003P8-KY for qemu-devel@nongnu.org; Mon, 18 Feb 2019 15:54:05 -0500 References: <20190218161822.3573-1-kwolf@redhat.com> <20190218161822.3573-10-kwolf@redhat.com> From: Eric Blake Message-ID: Date: Mon, 18 Feb 2019 14:53:58 -0600 MIME-Version: 1.0 In-Reply-To: <20190218161822.3573-10-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/12] block: Fix AioContext switch for drained node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, stefanha@redhat.com, berrange@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org On 2/18/19 10:18 AM, Kevin Wolf wrote: > When a drained node changes its AioContext, we need to move its > aio_disable_external() to the new context, too. > > Without this fix, drain_end will try to reenable the new context, which > has never been disabled, so an assertion failure is triggered. > > Signed-off-by: Kevin Wolf > --- > block.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org