* [Qemu-devel] [PATCH] tcg: add cs_base and flags to -d exec output
@ 2017-12-17 5:50 Paolo Bonzini
2017-12-18 18:56 ` Richard Henderson
2018-01-29 16:39 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-12-17 5:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
accel/tcg/cpu-exec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 4318441e4c..18c1a2aedb 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -146,8 +146,10 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu, TranslationBlock *itb)
uint8_t *tb_ptr = itb->tc.ptr;
qemu_log_mask_and_addr(CPU_LOG_EXEC, itb->pc,
- "Trace %p [%d: " TARGET_FMT_lx "] %s\n",
- itb->tc.ptr, cpu->cpu_index, itb->pc,
+ "Trace %d: %p ["
+ TARGET_FMT_lx "/" TARGET_FMT_lx "/%d] %s\n",
+ cpu->cpu_index, itb->tc.ptr,
+ itb->cs_base, itb->pc, itb->flags,
lookup_symbol(itb->pc));
#if defined(DEBUG_DISAS)
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tcg: add cs_base and flags to -d exec output
2017-12-17 5:50 [Qemu-devel] [PATCH] tcg: add cs_base and flags to -d exec output Paolo Bonzini
@ 2017-12-18 18:56 ` Richard Henderson
2018-01-29 16:39 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2017-12-18 18:56 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 12/16/2017 09:50 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> accel/tcg/cpu-exec.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> index 4318441e4c..18c1a2aedb 100644
> --- a/accel/tcg/cpu-exec.c
> +++ b/accel/tcg/cpu-exec.c
> @@ -146,8 +146,10 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu, TranslationBlock *itb)
> uint8_t *tb_ptr = itb->tc.ptr;
>
> qemu_log_mask_and_addr(CPU_LOG_EXEC, itb->pc,
> - "Trace %p [%d: " TARGET_FMT_lx "] %s\n",
> - itb->tc.ptr, cpu->cpu_index, itb->pc,
> + "Trace %d: %p ["
> + TARGET_FMT_lx "/" TARGET_FMT_lx "/%d] %s\n",
> + cpu->cpu_index, itb->tc.ptr,
> + itb->cs_base, itb->pc, itb->flags,
> lookup_symbol(itb->pc));
Thanks, applied to tcg-next.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: add cs_base and flags to -d exec output
2017-12-17 5:50 [Qemu-devel] [PATCH] tcg: add cs_base and flags to -d exec output Paolo Bonzini
2017-12-18 18:56 ` Richard Henderson
@ 2018-01-29 16:39 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2018-01-29 16:39 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers, Richard Henderson
On 17 December 2017 at 05:50, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> accel/tcg/cpu-exec.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> index 4318441e4c..18c1a2aedb 100644
> --- a/accel/tcg/cpu-exec.c
> +++ b/accel/tcg/cpu-exec.c
> @@ -146,8 +146,10 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu, TranslationBlock *itb)
> uint8_t *tb_ptr = itb->tc.ptr;
>
> qemu_log_mask_and_addr(CPU_LOG_EXEC, itb->pc,
> - "Trace %p [%d: " TARGET_FMT_lx "] %s\n",
> - itb->tc.ptr, cpu->cpu_index, itb->pc,
> + "Trace %d: %p ["
> + TARGET_FMT_lx "/" TARGET_FMT_lx "/%d] %s\n",
> + cpu->cpu_index, itb->tc.ptr,
> + itb->cs_base, itb->pc, itb->flags,
> lookup_symbol(itb->pc));
At the risk of having to update my log-parsing scripts again, I
notice that the output now looks a bit odd:
Trace 0: 0x7f70942390c0 [00000000/6aa01000/0x51080001] someFunction
in that the first two items in the [] have no preceding 0x but the
last one does.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-29 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-17 5:50 [Qemu-devel] [PATCH] tcg: add cs_base and flags to -d exec output Paolo Bonzini
2017-12-18 18:56 ` Richard Henderson
2018-01-29 16:39 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).