qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org, lvivier@redhat.com,
	alex.bennee@linaro.org
Cc: quintela@redhat.com
Subject: Re: [PATCH] tests/migration: Allow longer timeouts
Date: Mon, 12 Oct 2020 15:13:25 +0200	[thread overview]
Message-ID: <b2ca5be3-fa96-4ecd-32bc-26a2d27554bd@redhat.com> (raw)
In-Reply-To: <20201008160330.130431-1-dgilbert@redhat.com>

On 08/10/2020 18.03, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> In travis, with gcov and gprof we're seeing timeouts; hopefully fix
> this by increasing the test timeouts a bit, but for xbzrle ensure it
> really does get a couple of cycles through to test the cache.
> 
> I think the problem in travis is we have about 2 host CPU threads,
> in the test we have at least 3:
>    a) The vCPU thread (100% flat out)
>    b) The source migration thread
>    c) The destination migration thread
> 
> if (b) & (c) are slow for any reason - gcov+gperf or a slow host -
> then they're sharing one host CPU thread so limit the migration
> bandwidth.
> 
> Tested on my laptop with:
>    taskset -c 0,1 ./tests/qtest/migration-test -p /x86_64/migration
> 
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  tests/qtest/migration-test.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)

This seems to fix the gcov/gprof test indeed:

 https://travis-ci.com/github/huth/qemu/jobs/398270396

Thus:

Tested-by: Thomas Huth <thuth@redhat.com>

I'm also queuing this to my qtest-next branch (in case you don't plan a
migration pull request within the next days):

 https://gitlab.com/huth/qemu/-/commits/qtest-next/

 Thomas



  reply	other threads:[~2020-10-12 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 16:03 [PATCH] tests/migration: Allow longer timeouts Dr. David Alan Gilbert (git)
2020-10-12 13:13 ` Thomas Huth [this message]
2020-10-13  6:06   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2ca5be3-fa96-4ecd-32bc-26a2d27554bd@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).