From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/avr: Use vaddr type for $PC jumps
Date: Thu, 9 Oct 2025 21:30:16 -0700 [thread overview]
Message-ID: <b2d08405-876a-4d33-a05a-4aa3d5fca6c4@linaro.org> (raw)
In-Reply-To: <78a13e96-1404-484d-a985-6b403fd1462c@linaro.org>
On 10/9/25 19:56, Philippe Mathieu-Daudé wrote:
> Oh I see. Then avr_tr_insn_start() is also buggy?
Good question. It depends on how we view things.
At least once upon a time, the values in insn_start were all private to the target. They
were only consumed by restore_state_to_opc.
Over time there has been creep, where the first argument might be assumed to be the
virtual address. E.g. plugins? But beyond that?
r~
prev parent reply other threads:[~2025-10-10 4:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 20:05 [PATCH] target/avr: Use vaddr type for $PC jumps Philippe Mathieu-Daudé
2025-10-09 21:42 ` Richard Henderson
2025-10-10 2:56 ` Philippe Mathieu-Daudé
2025-10-10 4:30 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2d08405-876a-4d33-a05a-4aa3d5fca6c4@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).