Re: [PATCH v8 00/28] vfio-user client

[Steven Sistare <steven.sistare@oracle.com>]

On 3/14/2025 10:25 AM, Cédric Le Goater wrote:
> John,
> 
> +Steven, for the Live upsate series.
> 
> On 2/19/25 15:48, John Levon wrote:
>> This is the 8th revision of the vfio-user client implementation. The vfio-user
>> protocol allows for implementing (PCI) devices in another userspace process;
>> SPDK is one example, which includes a virtual NVMe implementation.
>>
>> The vfio-user framework consists of 3 parts:
>>   1) The VFIO user protocol specification.
>>   2) A client - the VFIO device in QEMU that encapsulates VFIO messages
>>      and sends them to the server.
>>   3) A server - a remote process that emulates a device.
>>
>> This patchset implements parts 1 and 2.
>>
>> It has been tested against libvfio-user test servers as well as SPDK.
>>
>> Thanks for previous reviews & comments.
> 
> This series is going in the right direction. Thanks for all the
> changes. However, I will postpone my review for the reasons below.
> 
> VFIO initial commit in 2012 was a single file adding support for a
> "vfio-pci" device. Since, the subsystem has changed a lot and it grew
> to +16K line of code. Over the years, we've had numerous additions,
> VFIO platform devices, s390x VFIO AP and CCW devices, migration
> support with dirty tracking, support for different host IOMMU backend
> devices, multifd, etc. All these additions never took the opportunity
> to introduce a VFIO interface for external usage and PPC, s390x,
> migration, backends subsystems happily and randomly peek and poke into
> it. The subsystem is now a happy jumble of disparate functions, with
> weak organization and names. The vfio-common.h header file is
> good example of the result.
> 
> It's time for a global code reshuffling. I'll take care of it (and
> I've already started) and this means nothing new (fixes are OK) will
> be merged before this is done. I hope I have made enough progress
> before the start of the QEMU 10.1 cycle. There won't be any functional
> changes, but there will be new files and new function names, so it's
> probably a real earthquake for your series.

Hi Cedric, as part of your reshuffling, can you incorporate the code cleanup
patches that I submitted in the live update series?

- Steve