From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GCfhS-0005JJ-9Y
	for qemu-devel@nongnu.org; Mon, 14 Aug 2006 12:54:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GCfhQ-0005J3-Rg
	for qemu-devel@nongnu.org; Mon, 14 Aug 2006 12:54:02 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GCfhQ-0005J0-Ls
	for qemu-devel@nongnu.org; Mon, 14 Aug 2006 12:54:00 -0400
Received: from [66.249.82.233] (helo=wx-out-0506.google.com)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GCfnH-0005HJ-7b
	for qemu-devel@nongnu.org; Mon, 14 Aug 2006 13:00:03 -0400
Received: by wx-out-0506.google.com with SMTP id r21so1255086wxc
	for <qemu-devel@nongnu.org>; Mon, 14 Aug 2006 09:53:59 -0700 (PDT)
Message-ID: <b2fa41d60608140953u6a077d6fx3995789e6b343f01@mail.gmail.com>
Date: Mon, 14 Aug 2006 20:53:58 +0400
From: "Igor Kovalenko" <igor.v.kovalenko@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_Part_193139_13163912.1155574438726"
Subject: [Qemu-devel] [PATCH] osdep.c fd leak fix
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

------=_Part_193139_13163912.1155574438726
Content-Type: multipart/alternative;
	boundary="----=_Part_193140_21502062.1155574438726"

------=_Part_193140_21502062.1155574438726
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi!

mkstemp() does open fd for us, no need to leak one file descriptor.
Please apply.

--
Kind Regards,
Igor V. Kovalenko

------=_Part_193140_21502062.1155574438726
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi!<br><br>mkstemp() does open fd for us, no need to leak one file descriptor.<br>Please apply.<br><br>--<br>Kind Regards,<br>Igor V. Kovalenko<br><br>

------=_Part_193140_21502062.1155574438726--

------=_Part_193139_13163912.1155574438726
Content-Type: text/plain; name=osdep-fd-leak.diff; charset=ANSI_X3.4-1968
Content-Transfer-Encoding: base64
X-Attachment-Id: f_eqv35age
Content-Disposition: attachment; filename="osdep-fd-leak.diff"

SW5kZXg6IG9zZGVwLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvcWVtdS9xZW11L29z
ZGVwLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTMKZGlmZiAtdSAtcjEuMTMgb3NkZXAuYwot
LS0gb3NkZXAuYwkzIEF1ZyAyMDA2IDE3OjUzOjE5IC0wMDAwCTEuMTMKKysrIG9zZGVwLmMJMTQg
QXVnIDIwMDYgMTY6NDg6MzkgLTAwMDAKQEAgLTEyMCw3ICsxMjAsOCBAQAogICAgICAgICB9CiAg
ICAgICAgIHNucHJpbnRmKHBoeXNfcmFtX2ZpbGUsIHNpemVvZihwaHlzX3JhbV9maWxlKSwgIiVz
L3FlbXVYWFhYWFgiLCAKICAgICAgICAgICAgICAgICAgdG1wZGlyKTsKLSAgICAgICAgaWYgKG1r
c3RlbXAocGh5c19yYW1fZmlsZSkgPCAwKSB7CisgICAgICAgIHBoeXNfcmFtX2ZkID0gbWtzdGVt
cChwaHlzX3JhbV9maWxlKTsKKyAgICAgICAgaWYgKHBoeXNfcmFtX2ZkIDwgMCkgewogICAgICAg
ICAgICAgZnByaW50ZihzdGRlcnIsIAogICAgICAgICAgICAgICAgICAgICAid2FybmluZzogY291
bGQgbm90IGNyZWF0ZSB0ZW1wb3JhcnkgZmlsZSBpbiAnJXMnLlxuIgogICAgICAgICAgICAgICAg
ICAgICAiVXNlIFFFTVVfVE1QRElSIHRvIHNlbGVjdCBhIGRpcmVjdG9yeSBpbiBhIHRtcGZzIGZp
bGVzeXN0ZW0uXG4iCkBAIC0xMjgsMTggKzEyOSwxMyBAQAogICAgICAgICAgICAgICAgICAgICB0
bXBkaXIpOwogICAgICAgICAgICAgc25wcmludGYocGh5c19yYW1fZmlsZSwgc2l6ZW9mKHBoeXNf
cmFtX2ZpbGUpLCAiJXMvcWVtdVhYWFhYWCIsIAogICAgICAgICAgICAgICAgICAgICAgIi90bXAi
KTsKLSAgICAgICAgICAgIGlmIChta3N0ZW1wKHBoeXNfcmFtX2ZpbGUpIDwgMCkgeworICAgICAg
ICAgICAgcGh5c19yYW1fZmQgPSBta3N0ZW1wKHBoeXNfcmFtX2ZpbGUpOworICAgICAgICAgICAg
aWYgKHBoeXNfcmFtX2ZkIDwgMCkgewogICAgICAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAi
Q291bGQgbm90IGNyZWF0ZSB0ZW1wb3JhcnkgbWVtb3J5IGZpbGUgJyVzJ1xuIiwgCiAgICAgICAg
ICAgICAgICAgICAgICAgICBwaHlzX3JhbV9maWxlKTsKICAgICAgICAgICAgICAgICBleGl0KDEp
OwogICAgICAgICAgICAgfQogICAgICAgICB9Ci0gICAgICAgIHBoeXNfcmFtX2ZkID0gb3Blbihw
aHlzX3JhbV9maWxlLCBPX0NSRUFUIHwgT19UUlVOQyB8IE9fUkRXUiwgMDYwMCk7Ci0gICAgICAg
IGlmIChwaHlzX3JhbV9mZCA8IDApIHsKLSAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiQ291
bGQgbm90IG9wZW4gdGVtcG9yYXJ5IG1lbW9yeSBmaWxlICclcydcbiIsIAotICAgICAgICAgICAg
ICAgICAgICBwaHlzX3JhbV9maWxlKTsKLSAgICAgICAgICAgIGV4aXQoMSk7Ci0gICAgICAgIH0K
ICAgICAgICAgdW5saW5rKHBoeXNfcmFtX2ZpbGUpOwogICAgIH0KICAgICBzaXplID0gKHNpemUg
KyA0MDk1KSAmIH40MDk1Owo=
------=_Part_193139_13163912.1155574438726--