From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJilb-0007Q1-PJ for qemu-devel@nongnu.org; Tue, 29 Jan 2008 00:12:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJilZ-0007Pp-EK for qemu-devel@nongnu.org; Tue, 29 Jan 2008 00:12:14 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJilZ-0007Pm-59 for qemu-devel@nongnu.org; Tue, 29 Jan 2008 00:12:13 -0500 Received: from wr-out-0506.google.com ([64.233.184.228]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JJilZ-000365-DU for qemu-devel@nongnu.org; Tue, 29 Jan 2008 00:12:13 -0500 Received: by wr-out-0506.google.com with SMTP id c37so3523744wra.19 for ; Mon, 28 Jan 2008 21:12:12 -0800 (PST) Message-ID: Date: Tue, 29 Jan 2008 08:12:12 +0300 From: "Igor Kovalenko" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6208_18082154.1201583532035" Subject: [Qemu-devel] [PATCH] implement more INQUIRY command replies for scsi disk Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_6208_18082154.1201583532035 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline >>From what I see there are more bits of scsi INQUIRY command which are mandatory, and this patch adds two mandatory and one optional scsi VPD page to that command reply. Also handled optional "command support data" request, with error reply. Please apply qemu-scsi-disk-inquiry-20080129-2.patch attached. With this patch I'm able to install openSUSE x86 on 10Gb scsi disk (emulated, image). Without this patch I see the following emulation error messages: scsi-disk: Orphaned request lsi_scsi: error: IO with unknown tag 65579 (tag number varies) and once lsi_scsi: error: Reselect with pending DMA Seems like Linux sym driver really does not like missing VPD replies, or there is some problem with lsi emulation in qemu. -- Kind regards, Igor V. Kovalenko ------=_Part_6208_18082154.1201583532035 Content-Type: application/octet-stream; name=qemu-scsi-disk-inquiry-20080129-2.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fbzzn3yq1 Content-Disposition: attachment; filename=qemu-scsi-disk-inquiry-20080129-2.patch SW5kZXg6IGh3L3Njc2ktZGlzay5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3FlbXUv cWVtdS9ody9zY3NpLWRpc2suYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xOQpkaWZmIC11IC1w IC1yMS4xOSBzY3NpLWRpc2suYwotLS0gaHcvc2NzaS1kaXNrLmMJMjQgRGVjIDIwMDcgMTQ6MzM6 MjQgLTAwMDAJMS4xOQorKysgaHcvc2NzaS1kaXNrLmMJMjkgSmFuIDIwMDggMDU6MDY6NTkgLTAw MDAKQEAgLTM2Miw4ICszNjIsMTIxIEBAIHN0YXRpYyBpbnQzMl90IHNjc2lfc2VuZF9jb21tYW5k KFNDU0lEZXYKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSAweDEyOgogICAgICAgICBEUFJJTlRG KCJJbnF1aXJ5IChsZW4gJWQpXG4iLCBsZW4pOwotICAgICAgICBpZiAobGVuIDwgMzYpIHsKLSAg ICAgICAgICAgIEJBREYoIklucXVpcnkgYnVmZmVyIHRvbyBzbWFsbCAoJWQpXG4iLCBsZW4pOwor ICAgICAgICBpZiAoYnVmWzFdICYgMHgyKSB7CisgICAgICAgICAgICAvLyBjb21tYW5kIHN1cHBv cnQgZGF0YQorICAgICAgICAgICAgLy8gb3B0aW9uYWwsIG5vdCBpbXBsZW1lbnRlZAorICAgICAg ICAgICAgQkFERigib3B0aW9uYWwgSU5RVUlSWSBjb21tYW5kIHN1cHBvcnQgcmVxdWVzdCBub3Qg aW1wbGVtZW50ZWRcbiIpOworICAgICAgICAgICAgZ290byBmYWlsOworICAgICAgICB9CisgICAg ICAgIGVsc2UgaWYgKGJ1ZlsxXSAmIDB4MSkgeworICAgICAgICAgICAgLy8gdml0YWwgcHJvZHVj dCBkYXRhCisgICAgICAgICAgICB1aW50OF90IHBhZ2VfY29kZSA9IGJ1ZlsyXTsKKyAgICAgICAg ICAgIGlmIChsZW4gPCA0KSB7CisgICAgICAgICAgICAgICAgQkFERigiRXJyb3I6IElucXVpcnkg KEVWUERbJTAyWF0pIGJ1ZmZlciBzaXplICVkIGlzIGxlc3MgdGhhbiA0XG4iLCBwYWdlX2NvZGUs IGxlbik7CisgICAgICAgICAgICAgICAgZ290byBmYWlsOworICAgICAgICAgICAgfQorCisgICAg ICAgICAgICBzd2l0Y2ggKHBhZ2VfY29kZSkgeworICAgICAgICAgICAgICAgIGNhc2UgMHgwMDoK KyAgICAgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAgICAgICAgLy8gc3VwcG9y dGVkIHBhZ2UgY29kZXMsIG1hbmRhdG9yeQorICAgICAgICAgICAgICAgICAgICAgICAgRFBSSU5U RigiSW5xdWlyeSBFVlBEW1N1cHBvcnRlZCBwYWdlc10gYnVmZmVyIHNpemUgJWRcbiIsIGxlbik7 CisKKyAgICAgICAgICAgICAgICAgICAgICAgIHItPmJ1Zl9sZW4gPSAwOworCisgICAgICAgICAg ICAgICAgICAgICAgICBpZiAoYmRydl9nZXRfdHlwZV9oaW50KHMtPmJkcnYpID09IEJEUlZfVFlQ RV9DRFJPTSkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIG91dGJ1ZltyLT5idWZfbGVu KytdID0gNTsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgb3V0YnVmW3ItPmJ1Zl9sZW4rK10gPSAwOworICAgICAgICAgICAgICAg ICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgICAgICAgICBvdXRidWZbci0+YnVmX2xlbisr XSA9IDB4MDA7IC8vIHRoaXMgcGFnZQorICAgICAgICAgICAgICAgICAgICAgICAgb3V0YnVmW3It PmJ1Zl9sZW4rK10gPSAweDAwOworICAgICAgICAgICAgICAgICAgICAgICAgb3V0YnVmW3ItPmJ1 Zl9sZW4rK10gPSAzOyAgICAvLyBudW1iZXIgb2YgcGFnZXMKKyAgICAgICAgICAgICAgICAgICAg ICAgIG91dGJ1ZltyLT5idWZfbGVuKytdID0gMHgwMDsgLy8gbGlzdCBvZiBzdXBwb3J0ZWQgcGFn ZXMgKHRoaXMgcGFnZSkKKyAgICAgICAgICAgICAgICAgICAgICAgIG91dGJ1ZltyLT5idWZfbGVu KytdID0gMHg4MDsgLy8gdW5pdCBzZXJpYWwgbnVtYmVyCisgICAgICAgICAgICAgICAgICAgICAg ICBvdXRidWZbci0+YnVmX2xlbisrXSA9IDB4ODM7IC8vIGRldmljZSBpZGVudGlmaWNhdGlvbgor ICAgICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAg ICAgICAgICAgIGNhc2UgMHg4MDoKKyAgICAgICAgICAgICAgICAgICAgeworICAgICAgICAgICAg ICAgICAgICAgICAgLy8gZGV2aWNlIHNlcmlhbCBudW1iZXIsIG9wdGlvbmFsCisgICAgICAgICAg ICAgICAgICAgICAgICBpZiAobGVuIDwgNCkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAg IEJBREYoIkVycm9yOiBFVlBEW1NlcmlhbCBudW1iZXJdIElucXVpcnkgYnVmZmVyIHNpemUgJWQg dG9vIHNtYWxsLCAlZCBuZWVkZWRcbiIsIGxlbiwgNCk7CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZ290byBmYWlsOworICAgICAgICAgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAg ICAgICAgICAgICAgICBEUFJJTlRGKCJJbnF1aXJ5IEVWUERbU2VyaWFsIG51bWJlcl0gYnVmZmVy IHNpemUgJWRcbiIsIGxlbik7CisKKyAgICAgICAgICAgICAgICAgICAgICAgIHItPmJ1Zl9sZW4g PSAwOworCisgICAgICAgICAgICAgICAgICAgICAgICAvLyBzdXBwb3J0ZWQgcGFnZSBjb2Rlcwor ICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGJkcnZfZ2V0X3R5cGVfaGludChzLT5iZHJ2KSA9 PSBCRFJWX1RZUEVfQ0RST00pIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBvdXRidWZb ci0+YnVmX2xlbisrXSA9IDU7CisgICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2UgeworICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG91dGJ1ZltyLT5idWZfbGVuKytdID0gMDsKKyAgICAg ICAgICAgICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgICAgICAgICAgb3V0YnVmW3It PmJ1Zl9sZW4rK10gPSAweDgwOyAvLyB0aGlzIHBhZ2UKKyAgICAgICAgICAgICAgICAgICAgICAg IG91dGJ1ZltyLT5idWZfbGVuKytdID0gMHgwMDsKKyAgICAgICAgICAgICAgICAgICAgICAgIG91 dGJ1ZltyLT5idWZfbGVuKytdID0gMHgwMTsgLy8gMSBieXRlIGRhdGEgZm9sbG93CisKKyAgICAg ICAgICAgICAgICAgICAgICAgIG91dGJ1ZltyLT5idWZfbGVuKytdID0gJzAnOyAvLyAxIGJ5dGUg ZGF0YSBmb2xsb3cKKyAgICAgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgICAg IGJyZWFrOworICAgICAgICAgICAgICAgIGNhc2UgMHg4MzoKKyAgICAgICAgICAgICAgICAgICAg eworICAgICAgICAgICAgICAgICAgICAgICAgLy8gZGV2aWNlIGlkZW50aWZpY2F0aW9uIHBhZ2Us IG1hbmRhdG9yeQorICAgICAgICAgICAgICAgICAgICAgICAgaW50IG1heF9sZW4gPSAyNTUgLSA4 OworICAgICAgICAgICAgICAgICAgICAgICAgaW50IGlkX2xlbiA9IHN0cmxlbihiZHJ2X2dldF9k ZXZpY2VfbmFtZShzLT5iZHJ2KSk7CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoaWRfbGVu ID4gbWF4X2xlbikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZF9sZW4gPSBtYXhfbGVu OworCisgICAgICAgICAgICAgICAgICAgICAgICBEUFJJTlRGKCJJbnF1aXJ5IEVWUERbRGV2aWNl IGlkZW50aWZpY2F0aW9uXSBidWZmZXIgc2l6ZSAlZFxuIiwgbGVuKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgIHItPmJ1Zl9sZW4gPSAwOworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGJk cnZfZ2V0X3R5cGVfaGludChzLT5iZHJ2KSA9PSBCRFJWX1RZUEVfQ0RST00pIHsKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICBvdXRidWZbci0+YnVmX2xlbisrXSA9IDU7CisgICAgICAgICAg ICAgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIG91dGJ1 ZltyLT5idWZfbGVuKytdID0gMDsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0KKworICAgICAg ICAgICAgICAgICAgICAgICAgb3V0YnVmW3ItPmJ1Zl9sZW4rK10gPSAweDgzOyAvLyB0aGlzIHBh Z2UKKyAgICAgICAgICAgICAgICAgICAgICAgIG91dGJ1ZltyLT5idWZfbGVuKytdID0gMHgwMDsK KyAgICAgICAgICAgICAgICAgICAgICAgIG91dGJ1ZltyLT5idWZfbGVuKytdID0gMyArIGlkX2xl bjsKKworICAgICAgICAgICAgICAgICAgICAgICAgb3V0YnVmW3ItPmJ1Zl9sZW4rK10gPSAweDI7 IC8vIEFTQ0lJCisgICAgICAgICAgICAgICAgICAgICAgICBvdXRidWZbci0+YnVmX2xlbisrXSA9 IDA7ICAgLy8gbm90IG9mZmljaWFsbHkgYXNzaWduZWQKKyAgICAgICAgICAgICAgICAgICAgICAg IG91dGJ1ZltyLT5idWZfbGVuKytdID0gMDsgICAvLyByZXNlcnZlZAorICAgICAgICAgICAgICAg ICAgICAgICAgb3V0YnVmW3ItPmJ1Zl9sZW4rK10gPSBpZF9sZW47IC8vIGxlbmd0aCBvZiBkYXRh IGZvbGxvd2luZworCisgICAgICAgICAgICAgICAgICAgICAgICBtZW1jcHkoJm91dGJ1ZltyLT5i dWZfbGVuXSwgYmRydl9nZXRfZGV2aWNlX25hbWUocy0+YmRydiksIGlkX2xlbik7CisgICAgICAg ICAgICAgICAgICAgICAgICByLT5idWZfbGVuICs9IGlkX2xlbjsKKyAgICAgICAgICAgICAgICAg ICAgfQorICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICBkZWZhdWx0 OgorICAgICAgICAgICAgICAgICAgICBCQURGKCJFcnJvcjogdW5zdXBwb3J0ZWQgSW5xdWlyeSAo RVZQRFslMDJYXSkgYnVmZmVyIHNpemUgJWRcbiIsIHBhZ2VfY29kZSwgbGVuKTsKKyAgICAgICAg ICAgICAgICAgICAgZ290byBmYWlsOworICAgICAgICAgICAgfQorICAgICAgICAgICAgLy8gZG9u ZSB3aXRoIEVWUEQKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgICAgIGVsc2Ug eworICAgICAgICAgICAgLy8gc3RhbmRhcmQgSU5RVUlSWSBkYXRhCisgICAgICAgICAgICBpZiAo YnVmWzJdICE9IDApIHsKKyAgICAgICAgICAgICAgICBCQURGKCJFcnJvcjogSW5xdWlyeSAoU1RB TkRBUkQpIHBhZ2Ugb3IgY29kZSBpcyBub24temVybyBbJTAyWF1cbiIsIGJ1ZlsyXSk7CisgICAg ICAgICAgICAgICAgZ290byBmYWlsOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICAvLyBQ QUdFIENPREUgPT0gMAorICAgICAgICAgICAgaWYgKGxlbiA8IDUpIHsKKyAgICAgICAgICAgICAg ICBCQURGKCJFcnJvcjogSW5xdWlyeSAoU1RBTkRBUkQpIGJ1ZmZlciBzaXplICVkIGlzIGxlc3Mg dGhhbiA1XG4iLCBsZW4pOworICAgICAgICAgICAgICAgIGdvdG8gZmFpbDsKKyAgICAgICAgICAg IH0KKworICAgICAgICAgICAgaWYgKGxlbiA8IDM2KSB7CisgICAgICAgICAgICAgICAgQkFERigi RXJyb3I6IElucXVpcnkgKFNUQU5EQVJEKSBidWZmZXIgc2l6ZSAlZCBpcyBsZXNzIHRoYW4gMzYg KFRPRE86IG9ubHkgNSByZXF1aXJlZClcbiIsIGxlbik7CisgICAgICAgICAgICB9CiAgICAgICAg IH0KIAltZW1zZXQob3V0YnVmLCAwLCAzNik7CiAJaWYgKGJkcnZfZ2V0X3R5cGVfaGludChzLT5i ZHJ2KSA9PSBCRFJWX1RZUEVfQ0RST00pIHsK ------=_Part_6208_18082154.1201583532035--