[Qemu-devel] [PATCH] simplify storing temporaries in env structure regardless of host/target long size

[Qemu-devel] [PATCH] simplify storing temporaries in env structure regardless of host/target long size

[Igor Kovalenko]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

This patch separates decision about storing temporaries in env
structure from target long size by introducing a macro
QEMU_TEMPORARY_IN_ENV
Makes it a bit easier to work around register allocation problems.
By default there is no change to generated code.

-- 
Kind regards,
Igor V. Kovalenko

[-- Attachment #2: qemu-temporary-in-env-macro.patch --]
[-- Type: application/octet-stream, Size: 1100 bytes --]

Index: target-i386/cpu.h
===================================================================
RCS file: /cvsroot/qemu/qemu/target-i386/cpu.h,v
retrieving revision 1.57
diff -u -p -r1.57 cpu.h
--- target-i386/cpu.h	3 Feb 2008 02:42:36 -0000	1.57
+++ target-i386/cpu.h	12 Feb 2008 18:43:07 -0000
@@ -467,7 +467,7 @@ typedef union {
 #define NB_MMU_MODES 2
 
 typedef struct CPUX86State {
-#if TARGET_LONG_BITS > HOST_LONG_BITS
+#if defined(QEMU_TEMPORARY_IN_ENV)
     /* temporaries if we cannot store them in host registers */
     target_ulong t0, t1, t2;
 #endif
Index: target-i386/exec.h
===================================================================
RCS file: /cvsroot/qemu/qemu/target-i386/exec.h,v
retrieving revision 1.41
diff -u -p -r1.41 exec.h
--- target-i386/exec.h	1 Feb 2008 10:50:09 -0000	1.41
+++ target-i386/exec.h	12 Feb 2008 18:43:07 -0000
@@ -33,6 +33,10 @@
 register struct CPUX86State *env asm(AREG0);
 
 #if TARGET_LONG_BITS > HOST_LONG_BITS
+#define QEMU_TEMPORARY_IN_ENV
+#endif
+
+#if defined(QEMU_TEMPORARY_IN_ENV)
 
 /* no registers can be used */
 #define T0 (env->t0)

Re: [Qemu-devel] [PATCH] simplify storing temporaries in env structure regardless of host/target long size

[Blue Swirl]

On 2/12/08, Igor Kovalenko <igor.v.kovalenko@gmail.com> wrote:
> This patch separates decision about storing temporaries in env
> structure from target long size by introducing a macro
> QEMU_TEMPORARY_IN_ENV
> Makes it a bit easier to work around register allocation problems.
> By default there is no change to generated code.

I'd move env->t0/t1/t2 to CPU_COMMON and the T0/T1/T2 logic to
hostregs_helper.h.

Re: [Qemu-devel] [PATCH] simplify storing temporaries in env structure regardless of host/target long size

[Igor Kovalenko]

On Feb 12, 2008 10:12 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> On 2/12/08, Igor Kovalenko <igor.v.kovalenko@gmail.com> wrote:
> > This patch separates decision about storing temporaries in env
> > structure from target long size by introducing a macro
> > QEMU_TEMPORARY_IN_ENV
> > Makes it a bit easier to work around register allocation problems.
> > By default there is no change to generated code.
>
> I'd move env->t0/t1/t2 to CPU_COMMON and the T0/T1/T2 logic to
> hostregs_helper.h.
>

I don't think the hostregs_helper.h is supposed to be used for that.
It knows nothing about env.

-- 
Kind regards,
Igor V. Kovalenko