From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JP0lQ-0001lj-NM for qemu-devel@nongnu.org; Tue, 12 Feb 2008 14:25:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JP0lL-0001ke-Ue for qemu-devel@nongnu.org; Tue, 12 Feb 2008 14:25:56 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JP0lL-0001kU-K7 for qemu-devel@nongnu.org; Tue, 12 Feb 2008 14:25:51 -0500 Received: from wa-out-1112.google.com ([209.85.146.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JP0lL-0003pF-BU for qemu-devel@nongnu.org; Tue, 12 Feb 2008 14:25:51 -0500 Received: by wa-out-1112.google.com with SMTP id k22so3269188waf.18 for ; Tue, 12 Feb 2008 11:25:44 -0800 (PST) Message-ID: Date: Tue, 12 Feb 2008 22:25:43 +0300 From: "Igor Kovalenko" Subject: Re: [Qemu-devel] [PATCH] simplify storing temporaries in env structure regardless of host/target long size In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Feb 12, 2008 10:12 PM, Blue Swirl wrote: > On 2/12/08, Igor Kovalenko wrote: > > This patch separates decision about storing temporaries in env > > structure from target long size by introducing a macro > > QEMU_TEMPORARY_IN_ENV > > Makes it a bit easier to work around register allocation problems. > > By default there is no change to generated code. > > I'd move env->t0/t1/t2 to CPU_COMMON and the T0/T1/T2 logic to > hostregs_helper.h. > I don't think the hostregs_helper.h is supposed to be used for that. It knows nothing about env. -- Kind regards, Igor V. Kovalenko