From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXjL4-0004nu-HD
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 17:11:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXjL3-0004lw-7A
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 17:11:02 -0400
Received: from [199.232.76.173] (port=40018 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXjL2-0004lm-WD
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 17:11:01 -0400
Received: from rv-out-0708.google.com ([209.85.198.251]:42616)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <igor.v.kovalenko@gmail.com>) id 1KXjL2-0007Zr-SP
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 17:11:01 -0400
Received: by rv-out-0708.google.com with SMTP id f25so1452484rvb.22
	for <qemu-devel@nongnu.org>; Mon, 25 Aug 2008 14:10:59 -0700 (PDT)
Message-ID: <b2fa41d60808251410y103d5267nb51ece89ba1743e0@mail.gmail.com>
Date: Tue, 26 Aug 2008 01:10:59 +0400
From: "Igor Kovalenko" <igor.v.kovalenko@gmail.com>
Subject: Re: [Qemu-devel] [5087] Fix more bugs in r5044
In-Reply-To: <E1KXiuX-0008MV-Nr@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KXiuX-0008MV-Nr@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Tue, Aug 26, 2008 at 12:43 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
> Revision: 5087
>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5087
> Author:   blueswir1
> Date:     2008-08-25 20:43:37 +0000 (Mon, 25 Aug 2008)
>
> Log Message:
> -----------
> Fix more bugs in r5044
>
> Modified Paths:
> --------------
>    trunk/audio/audio.c
>    trunk/i386-dis.c
>
> Modified: trunk/i386-dis.c
> ===================================================================
> --- trunk/i386-dis.c    2008-08-25 20:03:28 UTC (rev 5086)
> +++ trunk/i386-dis.c    2008-08-25 20:43:37 UTC (rev 5087)
> @@ -2826,7 +2826,7 @@
>  oappend (s)
>      const char *s;
>  {
> -  pstrcpy (obufp, (size_t)(obufp - obuf), s);
> +  pstrcpy (obufp, sizeof(obuf) - (size_t)(obufp - obuf), s);
>   obufp += strlen (s);
>  }
>
>

Now the disassembler output is truncated; you need to revert this part
of change to i386-dis.c
The problem is that obufp is not always a pointer into obuf data, see
i386-dis.c:2497      obufp = op1out;

-- 
Kind regards,
Igor V. Kovalenko