From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Khrn2-0003ke-AH for qemu-devel@nongnu.org; Mon, 22 Sep 2008 16:13:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Khrmw-0003gF-Nf for qemu-devel@nongnu.org; Mon, 22 Sep 2008 16:13:47 -0400 Received: from [199.232.76.173] (port=53936 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Khrmw-0003gC-Bg for qemu-devel@nongnu.org; Mon, 22 Sep 2008 16:13:42 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:42703) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Khrmv-0005f1-NG for qemu-devel@nongnu.org; Mon, 22 Sep 2008 16:13:42 -0400 Received: by gxk12 with SMTP id 12so3809063gxk.10 for ; Mon, 22 Sep 2008 13:13:11 -0700 (PDT) Message-ID: Date: Tue, 23 Sep 2008 00:13:11 +0400 From: "Igor Kovalenko" Subject: Re: [Qemu-devel] [PATCH] sparc64 reverse cas and casx arguments In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Sep 22, 2008 at 8:20 PM, Blue Swirl wrote: > On 9/21/08, Igor Kovalenko wrote: >> Hi! >> >> The following patch should fix a problem with sparc64 cas and casx >> emulation where value to be stored and value to be compared are passed >> in reverse order to helper function. >> > Thanks for spotting. I think a cleaner solution would be to rearrange > the code so that the argument names match the instruction field names. I think the problem is at call site but anyway obviously the committed change fixes the problem. >> PS: if anyone can send me a patch for gdb to load and use System.map >> file while doing remote debugging that would be great :) > > I have usually compiled the kernel with -g flag and then used the > vmlinux file when debugging. > ... I wanted to save some time building the kernel for officially released distribution (this time, gentoo 2008.0) -- Kind regards, Igor V. Kovalenko