From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LCi9X-00068T-OK
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 17:12:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LCi9W-000669-R5
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 17:12:31 -0500
Received: from [199.232.76.173] (port=59467 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LCi9W-00065m-K9
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 17:12:30 -0500
Received: from rn-out-0910.google.com ([64.233.170.185]:15252)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <igor.v.kovalenko@gmail.com>) id 1LCi9W-0006qC-Au
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 17:12:30 -0500
Received: by rn-out-0910.google.com with SMTP id 56so2830165rnw.8
	for <qemu-devel@nongnu.org>; Tue, 16 Dec 2008 14:12:28 -0800 (PST)
Message-ID: <b2fa41d60812161412p5c2fbe06n212322603a8faf9a@mail.gmail.com>
Date: Wed, 17 Dec 2008 01:12:27 +0300
From: "Igor Kovalenko" <igor.v.kovalenko@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Add rtl8139b
In-Reply-To: <D2A9FBFD-3844-46C5-BF9D-E46241FDD109@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <200812141850.mBEIoBtN019561@smtp11.dti.ne.jp>
	<20081216191957.GA15605@shareable.org>
	<b2fa41d60812161145p4d75277yc9c6805c7b48f34a@mail.gmail.com>
	<20081216204215.GC15605@shareable.org>
	<D2A9FBFD-3844-46C5-BF9D-E46241FDD109@web.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Dec 17, 2008 at 12:36 AM, Andreas F=E4rber <andreas.faerber@web.de>=
 wrote:
>
> Am 16.12.2008 um 21:42 schrieb Jamie Lokier:
>
>> Igor Kovalenko wrote:
>>>
>>> On Tue, Dec 16, 2008 at 10:19 PM, Jamie Lokier <jamie@shareable.org>
>>> wrote:
>>>>
>>>> takasi-y@ops.dti.ne.jp wrote:
>>>>>
>>>>> +                        " ne2k_pci pcnet rtl8139 rtl8139b e1000\n");
>>>>
>>>> On seeing this in qemu output, and with no documentation, it suggests
>>>> "rtl8139b" is a later device revision than "rtl8139", and preferable
>>>> to use for new VMs.
>>>>
>>>> Imho it would be better to write " rtl8139b rtl8139 " and of course
>>>> document that rtl8139b is an older device than rtl8139.
>>>>
>>>
>>> -net nic,model=3Drtl8139[,quirks=3D8139cplus|8139b] default to 8139cplu=
s
>>
>> Nice!  I'd change to [,revision=3D8139cplus|8139b], as it's not a quirk.
>
> In that case [,revision=3Dcplus|b] would be even simpler. :)
>

Well, no, C+ is a mode of operation supported on 8139 rev C chip, and
probably some later ones. Not "all older chips starting with rev b do
not have it". Extended mode can cause problems with some buggy C+ mode
drivers so it is sometimes handy to disable C+ mode and revert to the
other "compatible" but somewhat slower driver.

Maybe original poster's rationale is required to continue :)

--=20
Kind regards,
Igor V. Kovalenko