From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LxihC-000534-QR for qemu-devel@nongnu.org; Sat, 25 Apr 2009 10:17:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lxih7-00050G-BT for qemu-devel@nongnu.org; Sat, 25 Apr 2009 10:17:33 -0400 Received: from [199.232.76.173] (port=60257 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lxih7-00050D-8q for qemu-devel@nongnu.org; Sat, 25 Apr 2009 10:17:29 -0400 Received: from mail-bw0-f175.google.com ([209.85.218.175]:50783) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lxih6-0007oP-LY for qemu-devel@nongnu.org; Sat, 25 Apr 2009 10:17:29 -0400 Received: by bwz23 with SMTP id 23so1412660bwz.34 for ; Sat, 25 Apr 2009 07:17:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Sat, 25 Apr 2009 18:17:25 +0400 Message-ID: Subject: [Qemu-devel] [PATCH] sparc64 support TSB related MMU registers From: Igor Kovalenko Content-Type: multipart/mixed; boundary=001636c5b9e8c77d71046861c5e6 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --001636c5b9e8c77d71046861c5e6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Posting updated patch to the list... >>> On Fri, Apr 24, 2009 at 9:42 PM, Blue Swirl wrot= e: >>> =A0> >>> =A0> Nice, though I didn't notice any visible improvement in my tests. >>> >>> This early in boot process there is not much to output; and I test >>> =A0recent kernel which may use different startup sequence. >>> =A0I modified openbios cif handler to output arguments and I now can se= e >>> =A0visible difference. >>> >>> >>> =A0> >>> =A0> About the patch, there are a few problems: >>> =A0> - it breaks Sparc32 >>> >>> You mean it stops working? >> >> Does not even build. Fixed now. >>> =A0> - commented out code is ugly >>> =A0> - if and else should be on the same line as '{' or '}' >>> =A0> - long lines should be wrapped >>> =A0> - in the line: >>> =A0> + =A0 =A0return (((tag_access_register & 0x1fff)<<48)|(tag_access_= register >> 22)); >>> =A0> =A0there should be white space between ) and << and 48. >>> =A0> >>> >> >> Also the ")|(" in between is crowded. >> >> Maybe the coding style does not describe this well enough. BTW Supplying indent template would be great. Please see the updated patch qemu-sparc64-tsb-asi-2.patch attached. --=20 Kind regards, Igor V. Kovalenko --001636c5b9e8c77d71046861c5e6 Content-Type: application/octet-stream; name="qemu-sparc64-tsb-asi-2.patch" Content-Disposition: attachment; filename="qemu-sparc64-tsb-asi-2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ftye4xt40 SW5kZXg6IHRhcmdldC1zcGFyYy9vcF9oZWxwZXIuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0YXJnZXQtc3Bh cmMvb3BfaGVscGVyLmMJKHJldmlzaW9uIDcyNDkpCisrKyB0YXJnZXQtc3BhcmMvb3BfaGVscGVy LmMJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDU2IEBACiAjZW5kaWYKICNlbmRpZgogCisj aWZkZWYgVEFSR0VUX1NQQVJDNjQKKy8vIENhbGN1bGF0ZXMgVFNCIHBvaW50ZXIgdmFsdWUgZm9y IGZhdWx0IHBhZ2Ugc2l6ZSA4ayBvciA2NGsKK3N0YXRpYyB1aW50NjRfdCB1bHRyYXNwYXJjX3Rz Yl9wb2ludGVyKHVpbnQ2NF90IHRzYl9yZWdpc3RlciwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVpbnQ2NF90IHRhZ19hY2Nlc3NfcmVnaXN0ZXIsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcGFnZV9zaXplKQoreworICAgIHVpbnQ2 NF90IHRzYl9iYXNlID0gdHNiX3JlZ2lzdGVyICYgfjB4MWZmZlVMTDsKKyAgICBpbnQgdHNiX3Nw bGl0ID0gKGVudi0+ZG1tdXJlZ3NbNV0gJiAweDEwMDBVTEwpID8gMSA6IDA7CisgICAgaW50IHRz Yl9zaXplICA9IGVudi0+ZG1tdXJlZ3NbNV0gJiAweGY7CisKKyAgICAvLyBkaXNjYXJkIGxvd2Vy IDEzIGJpdHMgd2hpY2ggaG9sZCB0YWcgYWNjZXNzIGNvbnRleHQKKyAgICB1aW50NjRfdCB0YWdf YWNjZXNzX3ZhID0gdGFnX2FjY2Vzc19yZWdpc3RlciAmIH4weDFmZmZVTEw7CisKKyAgICAvLyBu b3cgcmVvcmRlciBiaXRzCisgICAgdWludDY0X3QgdHNiX2Jhc2VfbWFzayA9IH4weDFmZmZVTEw7 CisgICAgdWludDY0X3QgdmEgPSB0YWdfYWNjZXNzX3ZhOworCisgICAgLy8gbW92ZSB2YSBiaXRz IHRvIGNvcnJlY3QgcG9zaXRpb24KKyAgICBpZiAocGFnZV9zaXplID09IDgqMTAyNCkgeworICAg ICAgICB2YSA+Pj0gOTsKKyAgICB9IGVsc2UgaWYgKHBhZ2Vfc2l6ZSA9PSA2NCoxMDI0KSB7Cisg ICAgICAgIHZhID4+PSAxMjsKKyAgICB9CisKKyAgICBpZiAodHNiX3NpemUpIHsKKyAgICAgICAg dHNiX2Jhc2VfbWFzayA8PD0gdHNiX3NpemU7CisgICAgfQorCisgICAgLy8gY2FsY3VsYXRlIHRz Yl9iYXNlIG1hc2sgYW5kIGFkanVzdCB2YSBpZiBzcGxpdCBpcyBpbiB1c2UKKyAgICBpZiAodHNi X3NwbGl0KSB7CisgICAgICAgIGlmIChwYWdlX3NpemUgPT0gOCoxMDI0KSB7CisgICAgICAgICAg ICB2YSAmPSB+KDFVTEwgPDwgKDEzICsgdHNiX3NpemUpKTsKKyAgICAgICAgfSBlbHNlIGlmIChw YWdlX3NpemUgPT0gNjQqMTAyNCkgeworICAgICAgICAgICAgdmEgfD0gKDFVTEwgPDwgKDEzICsg dHNiX3NpemUpKTsKKyAgICAgICAgfQorICAgICAgICB0c2JfYmFzZV9tYXNrIDw8PSAxOworICAg IH0KKworICAgIHJldHVybiAoKHRzYl9iYXNlICYgdHNiX2Jhc2VfbWFzaykgfCAodmEgJiB+dHNi X2Jhc2VfbWFzaykpICYgfjB4ZlVMTDsKK30KKworLy8gQ2FsY3VsYXRlcyB0YWcgdGFyZ2V0IHJl Z2lzdGVyIHZhbHVlIGJ5IHJlb3JkZXJpbmcgYml0cworLy8gaW4gdGFnIGFjY2VzcyByZWdpc3Rl cgorc3RhdGljIHVpbnQ2NF90IHVsdHJhc3BhcmNfdGFnX3RhcmdldCh1aW50NjRfdCB0YWdfYWNj ZXNzX3JlZ2lzdGVyKQoreworICAgIHJldHVybiAoKHRhZ19hY2Nlc3NfcmVnaXN0ZXIgJiAweDFm ZmYpIDw8IDQ4KSB8ICh0YWdfYWNjZXNzX3JlZ2lzdGVyID4+IDIyKTsKK30KKworI2VuZGlmCisK IHN0YXRpYyBpbmxpbmUgdm9pZCBhZGRyZXNzX21hc2soQ1BVU3RhdGUgKmVudjEsIHRhcmdldF91 bG9uZyAqYWRkcikKIHsKICNpZmRlZiBUQVJHRVRfU1BBUkM2NApAQCAtMTY1MiwxMyArMTcwMiwz MSBAQAogICAgICAgICB7CiAgICAgICAgICAgICBpbnQgcmVnID0gKGFkZHIgPj4gMykgJiAweGY7 CiAKLSAgICAgICAgICAgIHJldCA9IGVudi0+aW1tdXJlZ3NbcmVnXTsKKyAgICAgICAgICAgIGlm IChyZWcgPT0gMCkgeworICAgICAgICAgICAgICAgIC8vIEktVFNCIFRhZyBUYXJnZXQgcmVnaXN0 ZXIKKyAgICAgICAgICAgICAgICByZXQgPSB1bHRyYXNwYXJjX3RhZ190YXJnZXQoZW52LT5pbW11 cmVnc1s2XSk7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIHJldCA9IGVu di0+aW1tdXJlZ3NbcmVnXTsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIH0KICAgICBjYXNlIDB4NTE6IC8vIEktTU1VIDhrIFRTQiBwb2ludGVyCisgICAgICAg IHsKKyAgICAgICAgICAgIC8vIGVudi0+aW1tdXJlZ3NbNV0gaG9sZHMgSS1NTVUgVFNCIHJlZ2lz dGVyIHZhbHVlCisgICAgICAgICAgICAvLyBlbnYtPmltbXVyZWdzWzZdIGhvbGRzIEktTU1VIFRh ZyBBY2Nlc3MgcmVnaXN0ZXIgdmFsdWUKKyAgICAgICAgICAgIHJldCA9IHVsdHJhc3BhcmNfdHNi X3BvaW50ZXIoZW52LT5pbW11cmVnc1s1XSwgZW52LT5pbW11cmVnc1s2XSwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOCoxMDI0KTsKKyAgICAgICAgICAgIGJyZWFr OworICAgICAgICB9CiAgICAgY2FzZSAweDUyOiAvLyBJLU1NVSA2NGsgVFNCIHBvaW50ZXIKLSAg ICAgICAgLy8gWFhYCi0gICAgICAgIGJyZWFrOworICAgICAgICB7CisgICAgICAgICAgICAvLyBl bnYtPmltbXVyZWdzWzVdIGhvbGRzIEktTU1VIFRTQiByZWdpc3RlciB2YWx1ZQorICAgICAgICAg ICAgLy8gZW52LT5pbW11cmVnc1s2XSBob2xkcyBJLU1NVSBUYWcgQWNjZXNzIHJlZ2lzdGVyIHZh bHVlCisgICAgICAgICAgICByZXQgPSB1bHRyYXNwYXJjX3RzYl9wb2ludGVyKGVudi0+aW1tdXJl Z3NbNV0sIGVudi0+aW1tdXJlZ3NbNl0sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIDY0KjEwMjQpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KICAgICBj YXNlIDB4NTU6IC8vIEktTU1VIGRhdGEgYWNjZXNzCiAgICAgICAgIHsKICAgICAgICAgICAgIGlu dCByZWcgPSAoYWRkciA+PiAzKSAmIDB4M2Y7CkBAIC0xNjc3LDkgKzE3NDUsMzAgQEAKICAgICAg ICAgewogICAgICAgICAgICAgaW50IHJlZyA9IChhZGRyID4+IDMpICYgMHhmOwogCi0gICAgICAg ICAgICByZXQgPSBlbnYtPmRtbXVyZWdzW3JlZ107CisgICAgICAgICAgICBpZiAocmVnID09IDAp IHsKKyAgICAgICAgICAgICAgICAvLyBELVRTQiBUYWcgVGFyZ2V0IHJlZ2lzdGVyCisgICAgICAg ICAgICAgICAgcmV0ID0gdWx0cmFzcGFyY190YWdfdGFyZ2V0KGVudi0+ZG1tdXJlZ3NbNl0pOwor ICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICByZXQgPSBlbnYtPmRtbXVyZWdz W3JlZ107CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQorICAg IGNhc2UgMHg1OTogLy8gRC1NTVUgOGsgVFNCIHBvaW50ZXIKKyAgICAgICAgeworICAgICAgICAg ICAgLy8gZW52LT5kbW11cmVnc1s1XSBob2xkcyBELU1NVSBUU0IgcmVnaXN0ZXIgdmFsdWUKKyAg ICAgICAgICAgIC8vIGVudi0+ZG1tdXJlZ3NbNl0gaG9sZHMgRC1NTVUgVGFnIEFjY2VzcyByZWdp c3RlciB2YWx1ZQorICAgICAgICAgICAgcmV0ID0gdWx0cmFzcGFyY190c2JfcG9pbnRlcihlbnYt PmRtbXVyZWdzWzVdLCBlbnYtPmRtbXVyZWdzWzZdLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICA4KjEwMjQpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0K KyAgICBjYXNlIDB4NWE6IC8vIEQtTU1VIDY0ayBUU0IgcG9pbnRlcgorICAgICAgICB7CisgICAg ICAgICAgICAvLyBlbnYtPmRtbXVyZWdzWzVdIGhvbGRzIEQtTU1VIFRTQiByZWdpc3RlciB2YWx1 ZQorICAgICAgICAgICAgLy8gZW52LT5kbW11cmVnc1s2XSBob2xkcyBELU1NVSBUYWcgQWNjZXNz IHJlZ2lzdGVyIHZhbHVlCisgICAgICAgICAgICByZXQgPSB1bHRyYXNwYXJjX3RzYl9wb2ludGVy KGVudi0+ZG1tdXJlZ3NbNV0sIGVudi0+ZG1tdXJlZ3NbNl0sCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIDY0KjEwMjQpOworICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgIH0KICAgICBjYXNlIDB4NWQ6IC8vIEQtTU1VIGRhdGEgYWNjZXNzCiAgICAgICAgIHsKICAg ICAgICAgICAgIGludCByZWcgPSAoYWRkciA+PiAzKSAmIDB4M2Y7CkBAIC0xNzA3LDggKzE3OTYs NiBAQAogICAgIGNhc2UgMHg3NjogLy8gRS1jYWNoZSB0YWcKICAgICBjYXNlIDB4N2U6IC8vIEUt Y2FjaGUgdGFnCiAgICAgICAgIGJyZWFrOwotICAgIGNhc2UgMHg1OTogLy8gRC1NTVUgOGsgVFNC IHBvaW50ZXIKLSAgICBjYXNlIDB4NWE6IC8vIEQtTU1VIDY0ayBUU0IgcG9pbnRlcgogICAgIGNh c2UgMHg1YjogLy8gRC1NTVUgZGF0YSBwb2ludGVyCiAgICAgY2FzZSAweDQ4OiAvLyBJbnRlcnJ1 cHQgZGlzcGF0Y2gsIFJPCiAgICAgY2FzZSAweDQ5OiAvLyBJbnRlcnJ1cHQgZGF0YSByZWNlaXZl Cg== --001636c5b9e8c77d71046861c5e6--