From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPjd8-0006TQ-FR for qemu-devel@nongnu.org; Sat, 11 Jul 2009 16:57:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPjd3-0006Q5-Cq for qemu-devel@nongnu.org; Sat, 11 Jul 2009 16:57:09 -0400 Received: from [199.232.76.173] (port=42001 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPjd3-0006Q2-7g for qemu-devel@nongnu.org; Sat, 11 Jul 2009 16:57:05 -0400 Received: from mail-fx0-f211.google.com ([209.85.220.211]:62332) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MPjd2-00047i-N0 for qemu-devel@nongnu.org; Sat, 11 Jul 2009 16:57:04 -0400 Received: by fxm7 with SMTP id 7so1296810fxm.34 for ; Sat, 11 Jul 2009 13:57:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20090711204356.GA6219@miranda.arrow> References: <20090711204356.GA6219@miranda.arrow> Date: Sun, 12 Jul 2009 00:57:03 +0400 Message-ID: Subject: Re: [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo From: Igor Kovalenko Content-Type: multipart/mixed; boundary=0016e6587a0cba6ae6046e7454f0 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --0016e6587a0cba6ae6046e7454f0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, Jul 12, 2009 at 12:43 AM, Stuart Brady wrote: > On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote: >> It is clear that intention is to byte-swap value to be written, not >> the target address. > > @@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta > =A0 =A0 case 0x89: // Secondary LE > =A0 =A0 =A0 =A0 switch(size) { > =A0 =A0 =A0 =A0 case 2: > - =A0 =A0 =A0 =A0 =A0 =A0addr =3D bswap16(addr); > + =A0 =A0 =A0 =A0 =A0 =A0addr =3D bswap16(val); > =A0 =A0 =A0 =A0 =A0 =A0 ^^^^ > Shouldn't that be 'val =3D bswap16(val)' (and likewise for the 32-bit and > 64-bit cases)? =A0Also needs a 'signed-off-by:'... > > Cheers, > -- > Stuart Brady > Thanks, that part I did not runtime-tested. Not sure if those asi stores are of any use for user-mode emulator. Please find attached the corrected version. Signed-off-by: igor.v.kovalenko@gmail.com --=20 Kind regards, Igor V. Kovalenko --0016e6587a0cba6ae6046e7454f0 Content-Type: application/octet-stream; name=sparc64-le-typo Content-Disposition: attachment; filename=sparc64-le-typo Content-Transfer-Encoding: base64 X-Attachment-Id: f_fx0tf7uf0 SW5kZXg6IHFlbXUtdHJ1bmsvdGFyZ2V0LXNwYXJjL29wX2hlbHBlci5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHFlbXUtdHJ1bmsub3JpZy90YXJnZXQtc3BhcmMvb3BfaGVscGVyLmMKKysrIHFlbXUtdHJ1bmsv dGFyZ2V0LXNwYXJjL29wX2hlbHBlci5jCkBAIC0xOTQ5LDEzICsxOTQ5LDEzIEBAIHZvaWQgaGVs cGVyX3N0X2FzaSh0YXJnZXRfdWxvbmcgYWRkciwgdGEKICAgICBjYXNlIDB4ODk6IC8vIFNlY29u ZGFyeSBMRQogICAgICAgICBzd2l0Y2goc2l6ZSkgewogICAgICAgICBjYXNlIDI6Ci0gICAgICAg ICAgICBhZGRyID0gYnN3YXAxNihhZGRyKTsKKyAgICAgICAgICAgIHZhbCA9IGJzd2FwMTYodmFs KTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDQ6Ci0gICAgICAgICAgICBhZGRy ID0gYnN3YXAzMihhZGRyKTsKKyAgICAgICAgICAgIHZhbCA9IGJzd2FwMzIodmFsKTsKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDg6Ci0gICAgICAgICAgICBhZGRyID0gYnN3YXA2 NChhZGRyKTsKKyAgICAgICAgICAgIHZhbCA9IGJzd2FwNjQodmFsKTsKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgYnJlYWs7CkBAIC0yMzc1LDEzICsy Mzc1LDEzIEBAIHZvaWQgaGVscGVyX3N0X2FzaSh0YXJnZXRfdWxvbmcgYWRkciwgdGEKICAgICBj YXNlIDB4ODk6IC8vIFNlY29uZGFyeSBMRQogICAgICAgICBzd2l0Y2goc2l6ZSkgewogICAgICAg ICBjYXNlIDI6Ci0gICAgICAgICAgICBhZGRyID0gYnN3YXAxNihhZGRyKTsKKyAgICAgICAgICAg IHZhbCA9IGJzd2FwMTYodmFsKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDQ6 Ci0gICAgICAgICAgICBhZGRyID0gYnN3YXAzMihhZGRyKTsKKyAgICAgICAgICAgIHZhbCA9IGJz d2FwMzIodmFsKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDg6Ci0gICAgICAg ICAgICBhZGRyID0gYnN3YXA2NChhZGRyKTsKKyAgICAgICAgICAgIHZhbCA9IGJzd2FwNjQodmFs KTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgYnJl YWs7Cg== --0016e6587a0cba6ae6046e7454f0--