Re: [PATCH v5 07/29] s390x/diag: Implement DIAG 320 subcode 1

[Collin Walling <walling@linux.ibm.com>]

On 8/27/25 10:35, Zhuoying Cai wrote:
> On 8/26/25 6:30 PM, Jared Rossi wrote:
>>
>>
>> On 8/18/25 5:43 PM, Zhuoying Cai wrote:

[...]

>>> +
>>> +struct VCStorageSizeBlock {
>>> +    uint32_t length;
>>> +    uint8_t reserved0[3];
>>> +    uint8_t version;
>>> +    uint32_t reserved1[6];
>>> +    uint16_t total_vc_ct;
>>> +    uint16_t max_vc_ct;
>>> +    uint32_t reserved3[11];
>>> +    uint32_t max_single_vcb_len;
>>> +    uint32_t total_vcb_len;
>>> +    uint32_t reserved4[10];
>>> +};
>>> +typedef struct VCStorageSizeBlock VCStorageSizeBlock;
>> Previous versions included a build bug message for the size of this 
>> structure,
>> was it dropped by mistake?
>>
> 
> Thanks for pointing it out. The use of the build error message was
> misunderstood as unnecessary in the last version.
> 
> I'll add it back in the next version.
> 

Yes, this was my call and I should've asked for clarity on it before
claiming it wasn't needed.  That was my bad.

[...]

-- 
Regards,
  Collin