From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] Add support for a helper with 7 arguments
Date: Fri, 7 Feb 2020 12:14:40 +0000 [thread overview]
Message-ID: <b308434a-1ee8-4fb5-0e60-4dfdd047c959@linaro.org> (raw)
In-Reply-To: <1580942510-2820-1-git-send-email-tsimpson@quicinc.com>
On 2/5/20 10:41 PM, Taylor Simpson wrote:
> Currently, helpers can only take up to 6 arguments. This patch adds the
> capability for up to 7 arguments. I have tested it with the Hexagon port
> that I am preparing for submission.
>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> include/exec/helper-gen.h | 13 +++++++++++++
> include/exec/helper-head.h | 2 ++
> include/exec/helper-proto.h | 6 ++++++
> include/exec/helper-tcg.h | 7 +++++++
> 4 files changed, 28 insertions(+)
Applied to tcg-next, since this is correct, and it does work.
But I encourage you to re-think your purely mechanical approach to the hexagon
port. It seems to me that you should be doing much more during the translation
phase so that you can minimize the number of helpers that you require.
r~
next prev parent reply other threads:[~2020-02-07 12:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 22:41 [PATCH] Add support for a helper with 7 arguments Taylor Simpson
2020-02-06 6:02 ` Richard Henderson
2020-02-06 10:28 ` Richard Henderson
2020-02-06 14:03 ` Taylor Simpson
2020-02-06 15:35 ` Richard Henderson
2020-02-06 17:52 ` Taylor Simpson
2020-02-07 0:27 ` Richard Henderson
2020-02-07 4:46 ` Taylor Simpson
2020-02-07 8:53 ` Richard Henderson
2020-02-07 11:59 ` Taylor Simpson
2020-02-07 12:14 ` Richard Henderson [this message]
2020-02-07 12:43 ` Taylor Simpson
2020-02-07 15:49 ` Richard Henderson
2020-02-09 5:08 ` Taylor Simpson
2020-02-09 18:17 ` Richard Henderson
2020-02-09 20:51 ` Taylor Simpson
2020-02-10 4:54 ` Taylor Simpson
2020-02-10 16:33 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b308434a-1ee8-4fb5-0e60-4dfdd047c959@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).