From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com,
Palmer Dabbelt <palmer@dabbelt.com>, Bin Meng <bmeng@tinylab.org>
Subject: Re: [PATCH v11 2/3] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel()
Date: Mon, 6 Feb 2023 17:18:35 -0300 [thread overview]
Message-ID: <b3105db2-d36b-b12c-fd0b-863cf82f938f@ventanamicro.com> (raw)
In-Reply-To: <21b58cf5-af07-95e3-8253-29d5b12d12e1@linaro.org>
On 2/6/23 16:54, Richard Henderson wrote:
> On 2/6/23 04:00, Daniel Henrique Barboza wrote:
>> To not change the behavior of boards that aren't calling
>> riscv_load_init(), add an 'load_initrd' flag to riscv_load_kernel() and
>> allow these boards to opt out from initrd loading.
>
> Surely this is simply a bug for those boards.
>
> I cannot believe, for instance, that sifive_u should allow initrd and sifive_e must not.
>
> Backward compatible behaviour is had simply by not providing the command-line argument.
That makes sense but the question here is whether the sifive_e board supports
-initrd if the option is provided. I tend to believe that it does, and the current
code state is mostly an oversight (we forgot to add load_initrd() support for the
board) rather than an intentional design choice, but since I'm not sure about
it I opted for playing it safe.
If someone can guarantee that the sifive_e and the opentitan boards are capable of
-initrd loading I can re-send this patch without the 'load_initrd' flag.
Thanks,
Daniel
>
>
> r~
next prev parent reply other threads:[~2023-02-06 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 14:00 [PATCH v11 0/3] Consolidate all kernel init in load_kernel() Daniel Henrique Barboza
2023-02-06 14:00 ` [PATCH v11 1/3] hw/riscv: handle 32 bit CPUs kernel_entry in riscv_load_kernel() Daniel Henrique Barboza
2023-02-06 15:12 ` Philippe Mathieu-Daudé
2023-02-06 22:24 ` Alistair Francis
2023-02-06 14:00 ` [PATCH v11 2/3] hw/riscv/boot.c: consolidate all kernel init " Daniel Henrique Barboza
2023-02-06 15:10 ` Philippe Mathieu-Daudé
2023-02-06 19:54 ` Richard Henderson
2023-02-06 20:18 ` Daniel Henrique Barboza [this message]
2023-02-06 22:54 ` Alistair Francis
2023-02-06 14:00 ` [PATCH v11 3/3] hw/riscv/boot.c: make riscv_load_initrd() static Daniel Henrique Barboza
2023-02-09 0:36 ` [PATCH v11 0/3] Consolidate all kernel init in load_kernel() Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3105db2-d36b-b12c-fd0b-863cf82f938f@ventanamicro.com \
--to=dbarboza@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).