From: Shivaprasad G Bhat <sbhat@linux.ibm.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com,
qemu-devel@nongnu.org, sbhat@linux.vnet.ibm.com,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH v3 1/3] mem: move nvdimm_device_list to utilities
Date: Wed, 20 Nov 2019 13:31:34 +0530 [thread overview]
Message-ID: <b32efc6c-e71d-b5cd-b2df-32c684ab834e@linux.ibm.com> (raw)
In-Reply-To: <20191119081326.275531af@redhat.com>
Hi Igor,
On 11/19/2019 12:43 PM, Igor Mammedov wrote:
> On Mon, 14 Oct 2019 13:37:37 -0500
> Shivaprasad G Bhat <sbhat@linux.ibm.com> wrote:
>
>> nvdimm_device_list is required for parsing the list for devices
>> in subsequent patches. Move it to common utility area.
>>
>> Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
>> ---
>> hw/acpi/nvdimm.c | 28 +---------------------------
>> include/qemu/nvdimm-utils.h | 7 +++++++
>> util/Makefile.objs | 1 +
>> util/nvdimm-utils.c | 29 +++++++++++++++++++++++++++++
> instead of creating new file, why not to move it to existing hw/mem/nvdimm.c?
That would break the build for mips-softmmu. The mips has
CONFIG_ACPI_NVDIMM=y
and not CONFIG_NVDIMM. So, the build would break failing to fetch the
definition from
hw/mem/nvdimm.c.
I have the patch here from v2 of the series,
https://github.com/ShivaprasadGBhat/qemu/commit/00512a25e4852f174fe6c07bc5acb5ee7027e3de
Thanks,
Shivaprasad
next prev parent reply other threads:[~2019-11-20 8:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 18:37 [PATCH v3 0/3] ppc: spapr: virtual NVDIMM support Shivaprasad G Bhat
2019-10-14 18:37 ` [PATCH v3 1/3] mem: move nvdimm_device_list to utilities Shivaprasad G Bhat
2019-11-19 2:58 ` David Gibson
2019-11-19 7:13 ` Igor Mammedov
2019-11-20 8:01 ` Shivaprasad G Bhat [this message]
2019-11-20 9:35 ` Igor Mammedov
2019-10-14 18:37 ` [PATCH v3 2/3] spapr: Add NVDIMM device support Shivaprasad G Bhat
2019-11-22 4:30 ` David Gibson
2019-11-27 4:20 ` Bharata B Rao
2019-12-06 1:52 ` David Gibson
2019-12-11 4:14 ` Shivaprasad G Bhat
2019-12-11 8:05 ` Igor Mammedov
2019-12-12 8:52 ` Shivaprasad G Bhat
2020-01-03 0:45 ` David Gibson
2019-12-16 11:15 ` Shivaprasad G Bhat
2019-10-14 18:38 ` [PATCH v3 3/3] spapr: Add Hcalls to support PAPR NVDIMM device Shivaprasad G Bhat
2019-11-22 5:11 ` David Gibson
2019-12-17 6:10 ` Shivaprasad G Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b32efc6c-e71d-b5cd-b2df-32c684ab834e@linux.ibm.com \
--to=sbhat@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sbhat@linux.vnet.ibm.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).