Re: [PATCH v4 04/28] s390x: Guest support for Certificate Store Facility (CS)

[Collin Walling <walling@linux.ibm.com>]

On 7/21/25 17:30, Collin Walling wrote:
> On 7/11/25 17:10, Zhuoying Cai wrote:
>> DIAG 320 is supported when the certificate-store (CS) facility
>> is installed.
>>
>> Availability of CS facility is determined by byte 134 bit 5 of the
>> SCLP Read Info block. Byte 134's facilities cannot be represented
>> without the availability of the extended-length-SCCB, so add it as
>> a check for consistency.
>>
>> Note: secure IPL is not available for Secure Execution (SE) guests,
>> as their images are already integrity protected, and an additional
>> protection of the kernel by secure IPL is not necessary.
>>
>> Signed-off-by: Zhuoying Cai <zycai@linux.ibm.com>
> 
> For consistency with documentation, please change this from
> "S390_FEAT_DIAG_320" to "S390_FEAT_CERT_STORE".
> 

I also believe this patch and the subsequent patch #5 should be merged.
Functionally, this patch does nothing meaningful.  This introduces the
CPU feature and the next one makes use of it.  They're both relatively
small patches.

Make sure you merge the relevant information in the commit message.


-- 
Regards,
  Collin