From: Thomas Huth <thuth@redhat.com>
To: Paz Offer <poffer@nvidia.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: ISO C90 compilation error
Date: Thu, 29 Feb 2024 08:14:34 +0100 [thread overview]
Message-ID: <b333af78-88f8-4fc1-8d13-945e51d4bc55@redhat.com> (raw)
In-Reply-To: <MW4PR12MB6997B8D6225D08E8F3E2DE55A05F2@MW4PR12MB6997.namprd12.prod.outlook.com>
On 29/02/2024 08.03, Paz Offer wrote:
> Hi,
>
> I am trying to build my code with QEMU and getting compilation error
> according to the /ISO C90 /standard:
>
> const size_t buf_size = 31;
> char buffer[buf_size + 1];
>
> error: ISO C90 forbids array ‘buffer’ whose size can’t be evaluated
> [-Werror=vla]
>
> I noticed that the code builds with '-std=gnu11', which is newer then C90,
> so this is not clear to me why I get this error.
> Where is the correct place to specify the language version for this?
The "ISO C90" part of the error message is quite misleading here. It's
rather that we explicitly enabled -Werror=vla in our codebase recently:
https://gitlab.com/qemu-project/qemu/-/commit/64c1a5443528ac09d8cd50f365d6
See the commit description there for the rationale.
Thomas
next prev parent reply other threads:[~2024-02-29 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 7:03 ISO C90 compilation error Paz Offer
2024-02-29 7:14 ` Thomas Huth [this message]
2024-02-29 7:59 ` Daniel P. Berrangé
2024-02-29 9:41 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b333af78-88f8-4fc1-8d13-945e51d4bc55@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=poffer@nvidia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).