From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br07k-00005e-JZ for qemu-devel@nongnu.org; Mon, 03 Oct 2016 06:05:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1br07e-00087K-IY for qemu-devel@nongnu.org; Mon, 03 Oct 2016 06:05:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45505 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1br07e-00086n-DQ for qemu-devel@nongnu.org; Mon, 03 Oct 2016 06:05:22 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u93A3378145128 for ; Mon, 3 Oct 2016 06:05:21 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 25t6s160wc-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 03 Oct 2016 06:05:21 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Oct 2016 11:05:19 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3E26C2190023 for ; Mon, 3 Oct 2016 11:04:36 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u93A5HAG7602674 for ; Mon, 3 Oct 2016 10:05:17 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u93A5HTu023799 for ; Mon, 3 Oct 2016 06:05:17 -0400 References: <20160930142003.53232-1-pasic@linux.vnet.ibm.com> <0cba1e29-7337-04a3-bbd1-8dcdd4eebd1b@redhat.com> From: Halil Pasic Date: Mon, 3 Oct 2016 12:04:59 +0200 MIME-Version: 1.0 In-Reply-To: <0cba1e29-7337-04a3-bbd1-8dcdd4eebd1b@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="H5M6GTAo1ewpsp8iqtWwuakueLF7d0HWR" Message-Id: Subject: Re: [Qemu-devel] [PATCH 00/11] virtio migration: simplify vmstate helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: "Michael S . Tsirkin" , "Dr . David Alan Gilbert" , "Aneesh Kumar K . V" , Stefan Hajnoczi , Amit Shah , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --H5M6GTAo1ewpsp8iqtWwuakueLF7d0HWR From: Halil Pasic To: Paolo Bonzini , qemu-devel@nongnu.org Cc: "Michael S . Tsirkin" , "Dr . David Alan Gilbert" , "Aneesh Kumar K . V" , Stefan Hajnoczi , Amit Shah , Gerd Hoffmann Message-ID: Subject: Re: [Qemu-devel] [PATCH 00/11] virtio migration: simplify vmstate helper References: <20160930142003.53232-1-pasic@linux.vnet.ibm.com> <0cba1e29-7337-04a3-bbd1-8dcdd4eebd1b@redhat.com> In-Reply-To: <0cba1e29-7337-04a3-bbd1-8dcdd4eebd1b@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/30/2016 05:02 PM, Paolo Bonzini wrote: >=20 > On 30/09/2016 16:19, Halil Pasic wrote: >> > As a part of the long term effort to convert migration to vmstate t= he >> > migration of virtio devices was recently partially switched to vmsta= te >> > starting with the outer layer (commit 5943124cc "virtio: Migration >> > helper function and macro" and the subsequent "virtio-*: Wrap in >> > vmstate" commits). This was done by introducing a vmstate based wrap= per >> > driving the well know virtio migration process. As this transition i= s >> > still in progress, some synergies were left unexploited, and some th= ings >> > can be expressed in a more vmstatish way. > Another useful thing to do is to move code out of virtio_load and into = a > post_load callback of vmstate_virtio. >=20 > Paolo >=20 Hi Paolo, thanks for the review. I agree, but I see this out of scope for this patc= h series. If you like I could do something along the lines as a separate pa= tch. Cheers, Halil --H5M6GTAo1ewpsp8iqtWwuakueLF7d0HWR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAEBAgAGBQJX8i1cAAoJEA0vhuyXGx0AIBYP/jqrByOWRrfAMtfXR1oW2jAQ aMzyDVLutDgZgY28FfzAKYdHRCZDKWv4ic3gmIlzo/OiyOGVNgyI28F0dfxP27h8 gzUo+QnT3AzX3dKPS6T8wflhLeXLPwHohj50q7KP6pR1X+uouAZ1mYqQoUUu5iE8 gKSHlZegNUnrjwwGae7kcphLeqgtOgF3gS0NDMk+nudkWal3mnFOFQPvByBW/5Rn g+zUGFqXmCP4/zmHeLOxcQmGtHUk4sipZ+FI00bQzDTKj4kHCGGKMLnip2YFD/P5 y6WXWZ0SSZtA0EqT9M1dbnpxvKJ9MAcX/Lg8K0wTMaeK74WvkZnvJ4boY+qrmbBI VdY1+4YcxDURcTemeZoHgecqKNv+K2mAx28Buc5bpJD54QiMySMgNyDOAQMkJgu8 JcNVhsJ+5yOM1dLNkS1/pSTNmFR7ySEF0Ei/l1UeJfqfBmnd9NM/bh3lQPbPZGcI 1vzawVh++DXFdLVZ0KnDiYLwt2+6i7+SpYDsHiq9B63eSLEMn5rDXugEGFE/+b6Z J4nTQNC/7hjc3VGpQ1C/H/+lFdhAlHg60f7hb5t6B6mr2ZwYzMJ7GtJEFxihupCU kO/cMBnrWcER0tbPkSTdFOP915CBSKBPK9r0hVuPsah2tFvv196ZLRPZd1I3sRa+ jnPmX92ygSHmqKMZEvjR =Xhop -----END PGP SIGNATURE----- --H5M6GTAo1ewpsp8iqtWwuakueLF7d0HWR--