From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] ppc/pnv/pci: Clean up error messages
Date: Tue, 20 Jun 2023 08:00:07 +0200 [thread overview]
Message-ID: <b377e77f-eba2-128f-2103-dde829f5ef31@kaod.org> (raw)
In-Reply-To: <20230619233636.57452-1-joel@jms.id.au>
On 6/20/23 01:36, Joel Stanley wrote:
> The phb error macros add a newline for you, so remove the second one to
> avoid double whitespace.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> hw/pci-host/pnv_phb4.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
> index 542f9e293221..6232cbeee161 100644
> --- a/hw/pci-host/pnv_phb4.c
> +++ b/hw/pci-host/pnv_phb4.c
> @@ -133,13 +133,13 @@ static void pnv_phb4_rc_config_write(PnvPHB4 *phb, unsigned off,
> PCIDevice *pdev;
>
> if (size != 4) {
> - phb_error(phb, "rc_config_write invalid size %d\n", size);
> + phb_error(phb, "rc_config_write invalid size %d", size);
> return;
> }
>
> pdev = pci_find_device(pci->bus, 0, 0);
> if (!pdev) {
> - phb_error(phb, "rc_config_write device not found\n");
> + phb_error(phb, "rc_config_write device not found");
> return;
> }
>
> @@ -155,13 +155,13 @@ static uint64_t pnv_phb4_rc_config_read(PnvPHB4 *phb, unsigned off,
> uint64_t val;
>
> if (size != 4) {
> - phb_error(phb, "rc_config_read invalid size %d\n", size);
> + phb_error(phb, "rc_config_read invalid size %d", size);
> return ~0ull;
> }
>
> pdev = pci_find_device(pci->bus, 0, 0);
> if (!pdev) {
> - phb_error(phb, "rc_config_read device not found\n");
> + phb_error(phb, "rc_config_read device not found");
> return ~0ull;
> }
>
> @@ -1039,19 +1039,19 @@ static void pnv_pec_stk_nest_xscom_write(void *opaque, hwaddr addr,
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] &
> (PEC_NEST_STK_BAR_EN_MMIO0 |
> PEC_NEST_STK_BAR_EN_MMIO1)) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xffffffffff000000ull;
> break;
> case PEC_NEST_STK_PHB_REGS_BAR:
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_PHB) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xffffffffffc00000ull;
> break;
> case PEC_NEST_STK_INT_BAR:
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_INT) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xfffffff000000000ull;
> break;
next prev parent reply other threads:[~2023-06-20 6:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 23:36 [PATCH] ppc/pnv/pci: Clean up error messages Joel Stanley
2023-06-20 5:58 ` Philippe Mathieu-Daudé
2023-06-20 6:00 ` Cédric Le Goater [this message]
2023-06-23 9:28 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b377e77f-eba2-128f-2103-dde829f5ef31@kaod.org \
--to=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).