From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7833DEB64D7 for ; Tue, 20 Jun 2023 06:03:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBUQp-0006AU-D2; Tue, 20 Jun 2023 02:01:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBUPZ-0004q7-P6; Tue, 20 Jun 2023 02:00:20 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBUPV-0004gQ-TX; Tue, 20 Jun 2023 02:00:16 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4QlbZg33ybz4x3N; Tue, 20 Jun 2023 16:00:11 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QlbZf1wYNz4wjF; Tue, 20 Jun 2023 16:00:09 +1000 (AEST) Message-ID: Date: Tue, 20 Jun 2023 08:00:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] ppc/pnv/pci: Clean up error messages Content-Language: en-US To: Joel Stanley , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org References: <20230619233636.57452-1-joel@jms.id.au> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20230619233636.57452-1-joel@jms.id.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=rj0j=CI=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.09, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/20/23 01:36, Joel Stanley wrote: > The phb error macros add a newline for you, so remove the second one to > avoid double whitespace. > > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/pci-host/pnv_phb4.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c > index 542f9e293221..6232cbeee161 100644 > --- a/hw/pci-host/pnv_phb4.c > +++ b/hw/pci-host/pnv_phb4.c > @@ -133,13 +133,13 @@ static void pnv_phb4_rc_config_write(PnvPHB4 *phb, unsigned off, > PCIDevice *pdev; > > if (size != 4) { > - phb_error(phb, "rc_config_write invalid size %d\n", size); > + phb_error(phb, "rc_config_write invalid size %d", size); > return; > } > > pdev = pci_find_device(pci->bus, 0, 0); > if (!pdev) { > - phb_error(phb, "rc_config_write device not found\n"); > + phb_error(phb, "rc_config_write device not found"); > return; > } > > @@ -155,13 +155,13 @@ static uint64_t pnv_phb4_rc_config_read(PnvPHB4 *phb, unsigned off, > uint64_t val; > > if (size != 4) { > - phb_error(phb, "rc_config_read invalid size %d\n", size); > + phb_error(phb, "rc_config_read invalid size %d", size); > return ~0ull; > } > > pdev = pci_find_device(pci->bus, 0, 0); > if (!pdev) { > - phb_error(phb, "rc_config_read device not found\n"); > + phb_error(phb, "rc_config_read device not found"); > return ~0ull; > } > > @@ -1039,19 +1039,19 @@ static void pnv_pec_stk_nest_xscom_write(void *opaque, hwaddr addr, > if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & > (PEC_NEST_STK_BAR_EN_MMIO0 | > PEC_NEST_STK_BAR_EN_MMIO1)) { > - phb_pec_error(pec, "Changing enabled BAR unsupported\n"); > + phb_pec_error(pec, "Changing enabled BAR unsupported"); > } > phb->nest_regs[reg] = val & 0xffffffffff000000ull; > break; > case PEC_NEST_STK_PHB_REGS_BAR: > if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_PHB) { > - phb_pec_error(pec, "Changing enabled BAR unsupported\n"); > + phb_pec_error(pec, "Changing enabled BAR unsupported"); > } > phb->nest_regs[reg] = val & 0xffffffffffc00000ull; > break; > case PEC_NEST_STK_INT_BAR: > if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_INT) { > - phb_pec_error(pec, "Changing enabled BAR unsupported\n"); > + phb_pec_error(pec, "Changing enabled BAR unsupported"); > } > phb->nest_regs[reg] = val & 0xfffffff000000000ull; > break;