* [PATCH] ppc/pnv/pci: Clean up error messages
@ 2023-06-19 23:36 Joel Stanley
2023-06-20 5:58 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Joel Stanley @ 2023-06-19 23:36 UTC (permalink / raw)
To: Cédric Le Goater, qemu-ppc; +Cc: qemu-devel
The phb error macros add a newline for you, so remove the second one to
avoid double whitespace.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
hw/pci-host/pnv_phb4.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 542f9e293221..6232cbeee161 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -133,13 +133,13 @@ static void pnv_phb4_rc_config_write(PnvPHB4 *phb, unsigned off,
PCIDevice *pdev;
if (size != 4) {
- phb_error(phb, "rc_config_write invalid size %d\n", size);
+ phb_error(phb, "rc_config_write invalid size %d", size);
return;
}
pdev = pci_find_device(pci->bus, 0, 0);
if (!pdev) {
- phb_error(phb, "rc_config_write device not found\n");
+ phb_error(phb, "rc_config_write device not found");
return;
}
@@ -155,13 +155,13 @@ static uint64_t pnv_phb4_rc_config_read(PnvPHB4 *phb, unsigned off,
uint64_t val;
if (size != 4) {
- phb_error(phb, "rc_config_read invalid size %d\n", size);
+ phb_error(phb, "rc_config_read invalid size %d", size);
return ~0ull;
}
pdev = pci_find_device(pci->bus, 0, 0);
if (!pdev) {
- phb_error(phb, "rc_config_read device not found\n");
+ phb_error(phb, "rc_config_read device not found");
return ~0ull;
}
@@ -1039,19 +1039,19 @@ static void pnv_pec_stk_nest_xscom_write(void *opaque, hwaddr addr,
if (phb->nest_regs[PEC_NEST_STK_BAR_EN] &
(PEC_NEST_STK_BAR_EN_MMIO0 |
PEC_NEST_STK_BAR_EN_MMIO1)) {
- phb_pec_error(pec, "Changing enabled BAR unsupported\n");
+ phb_pec_error(pec, "Changing enabled BAR unsupported");
}
phb->nest_regs[reg] = val & 0xffffffffff000000ull;
break;
case PEC_NEST_STK_PHB_REGS_BAR:
if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_PHB) {
- phb_pec_error(pec, "Changing enabled BAR unsupported\n");
+ phb_pec_error(pec, "Changing enabled BAR unsupported");
}
phb->nest_regs[reg] = val & 0xffffffffffc00000ull;
break;
case PEC_NEST_STK_INT_BAR:
if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_INT) {
- phb_pec_error(pec, "Changing enabled BAR unsupported\n");
+ phb_pec_error(pec, "Changing enabled BAR unsupported");
}
phb->nest_regs[reg] = val & 0xfffffff000000000ull;
break;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ppc/pnv/pci: Clean up error messages
2023-06-19 23:36 [PATCH] ppc/pnv/pci: Clean up error messages Joel Stanley
@ 2023-06-20 5:58 ` Philippe Mathieu-Daudé
2023-06-20 6:00 ` Cédric Le Goater
2023-06-23 9:28 ` Cédric Le Goater
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-06-20 5:58 UTC (permalink / raw)
To: Joel Stanley, Cédric Le Goater, qemu-ppc; +Cc: qemu-devel
On 20/6/23 01:36, Joel Stanley wrote:
> The phb error macros add a newline for you, so remove the second one to
> avoid double whitespace.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> hw/pci-host/pnv_phb4.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc/pnv/pci: Clean up error messages
2023-06-19 23:36 [PATCH] ppc/pnv/pci: Clean up error messages Joel Stanley
2023-06-20 5:58 ` Philippe Mathieu-Daudé
@ 2023-06-20 6:00 ` Cédric Le Goater
2023-06-23 9:28 ` Cédric Le Goater
2 siblings, 0 replies; 4+ messages in thread
From: Cédric Le Goater @ 2023-06-20 6:00 UTC (permalink / raw)
To: Joel Stanley, qemu-ppc; +Cc: qemu-devel
On 6/20/23 01:36, Joel Stanley wrote:
> The phb error macros add a newline for you, so remove the second one to
> avoid double whitespace.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> hw/pci-host/pnv_phb4.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
> index 542f9e293221..6232cbeee161 100644
> --- a/hw/pci-host/pnv_phb4.c
> +++ b/hw/pci-host/pnv_phb4.c
> @@ -133,13 +133,13 @@ static void pnv_phb4_rc_config_write(PnvPHB4 *phb, unsigned off,
> PCIDevice *pdev;
>
> if (size != 4) {
> - phb_error(phb, "rc_config_write invalid size %d\n", size);
> + phb_error(phb, "rc_config_write invalid size %d", size);
> return;
> }
>
> pdev = pci_find_device(pci->bus, 0, 0);
> if (!pdev) {
> - phb_error(phb, "rc_config_write device not found\n");
> + phb_error(phb, "rc_config_write device not found");
> return;
> }
>
> @@ -155,13 +155,13 @@ static uint64_t pnv_phb4_rc_config_read(PnvPHB4 *phb, unsigned off,
> uint64_t val;
>
> if (size != 4) {
> - phb_error(phb, "rc_config_read invalid size %d\n", size);
> + phb_error(phb, "rc_config_read invalid size %d", size);
> return ~0ull;
> }
>
> pdev = pci_find_device(pci->bus, 0, 0);
> if (!pdev) {
> - phb_error(phb, "rc_config_read device not found\n");
> + phb_error(phb, "rc_config_read device not found");
> return ~0ull;
> }
>
> @@ -1039,19 +1039,19 @@ static void pnv_pec_stk_nest_xscom_write(void *opaque, hwaddr addr,
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] &
> (PEC_NEST_STK_BAR_EN_MMIO0 |
> PEC_NEST_STK_BAR_EN_MMIO1)) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xffffffffff000000ull;
> break;
> case PEC_NEST_STK_PHB_REGS_BAR:
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_PHB) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xffffffffffc00000ull;
> break;
> case PEC_NEST_STK_INT_BAR:
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_INT) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xfffffff000000000ull;
> break;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ppc/pnv/pci: Clean up error messages
2023-06-19 23:36 [PATCH] ppc/pnv/pci: Clean up error messages Joel Stanley
2023-06-20 5:58 ` Philippe Mathieu-Daudé
2023-06-20 6:00 ` Cédric Le Goater
@ 2023-06-23 9:28 ` Cédric Le Goater
2 siblings, 0 replies; 4+ messages in thread
From: Cédric Le Goater @ 2023-06-23 9:28 UTC (permalink / raw)
To: Joel Stanley, qemu-ppc; +Cc: qemu-devel
On 6/20/23 01:36, Joel Stanley wrote:
> The phb error macros add a newline for you, so remove the second one to
> avoid double whitespace.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Applied to ppc-next.
Thanks,
C.
> ---
> hw/pci-host/pnv_phb4.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
> index 542f9e293221..6232cbeee161 100644
> --- a/hw/pci-host/pnv_phb4.c
> +++ b/hw/pci-host/pnv_phb4.c
> @@ -133,13 +133,13 @@ static void pnv_phb4_rc_config_write(PnvPHB4 *phb, unsigned off,
> PCIDevice *pdev;
>
> if (size != 4) {
> - phb_error(phb, "rc_config_write invalid size %d\n", size);
> + phb_error(phb, "rc_config_write invalid size %d", size);
> return;
> }
>
> pdev = pci_find_device(pci->bus, 0, 0);
> if (!pdev) {
> - phb_error(phb, "rc_config_write device not found\n");
> + phb_error(phb, "rc_config_write device not found");
> return;
> }
>
> @@ -155,13 +155,13 @@ static uint64_t pnv_phb4_rc_config_read(PnvPHB4 *phb, unsigned off,
> uint64_t val;
>
> if (size != 4) {
> - phb_error(phb, "rc_config_read invalid size %d\n", size);
> + phb_error(phb, "rc_config_read invalid size %d", size);
> return ~0ull;
> }
>
> pdev = pci_find_device(pci->bus, 0, 0);
> if (!pdev) {
> - phb_error(phb, "rc_config_read device not found\n");
> + phb_error(phb, "rc_config_read device not found");
> return ~0ull;
> }
>
> @@ -1039,19 +1039,19 @@ static void pnv_pec_stk_nest_xscom_write(void *opaque, hwaddr addr,
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] &
> (PEC_NEST_STK_BAR_EN_MMIO0 |
> PEC_NEST_STK_BAR_EN_MMIO1)) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xffffffffff000000ull;
> break;
> case PEC_NEST_STK_PHB_REGS_BAR:
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_PHB) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xffffffffffc00000ull;
> break;
> case PEC_NEST_STK_INT_BAR:
> if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_INT) {
> - phb_pec_error(pec, "Changing enabled BAR unsupported\n");
> + phb_pec_error(pec, "Changing enabled BAR unsupported");
> }
> phb->nest_regs[reg] = val & 0xfffffff000000000ull;
> break;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-23 9:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19 23:36 [PATCH] ppc/pnv/pci: Clean up error messages Joel Stanley
2023-06-20 5:58 ` Philippe Mathieu-Daudé
2023-06-20 6:00 ` Cédric Le Goater
2023-06-23 9:28 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).