From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwZad-00023w-MK for qemu-devel@nongnu.org; Mon, 25 Sep 2017 16:02:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwZac-0005XA-Pt for qemu-devel@nongnu.org; Mon, 25 Sep 2017 16:02:51 -0400 References: <20170925122808.14561-1-kwolf@redhat.com> From: John Snow Message-ID: Date: Mon, 25 Sep 2017 16:02:43 -0400 MIME-Version: 1.0 In-Reply-To: <20170925122808.14561-1-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com On 09/25/2017 08:28 AM, Kevin Wolf wrote: > This is a step towards making the commit job flexible enough that it can > work with any kind of block graph. Currently, it requires that not only > the top and base node of the commit operation are specified, but also > the active layer of the backing file chain. Of course, the assumption > that a single active layer exists is invalid. > > This series makes the commit job consider other roots as well so that > all parent nodes of the top node get their backing file updated and stay > valid after the commit job completes. > > With this, we should have all of the prerequisites for a follow-up > series that adds a new and clean blockdev-commit QMP command which > doesn't require an option for the active layer and which accepts node > names instead of file names for base and top. > > Kevin Wolf (5): > block: Introduce BdrvChildRole.update_filename > commit: Support multiple roots above top node > qemu-iotests: Allow QMP pretty printing in common.qemu > qemu-iotests: Test commit block job where top has two parents > commit: Remove overlay_bs > > include/block/block.h | 3 +- > include/block/block_int.h | 6 + > block.c | 91 +++-- > block/commit.c | 64 +--- > tests/qemu-iotests/030 | 4 - > tests/qemu-iotests/191 | 152 ++++++++ > tests/qemu-iotests/191.out | 827 +++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/common.qemu | 14 +- > tests/qemu-iotests/group | 1 + > 9 files changed, 1078 insertions(+), 84 deletions(-) > create mode 100755 tests/qemu-iotests/191 > create mode 100644 tests/qemu-iotests/191.out > Does this depend on another series?