From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: armbru@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
pbonzini@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper
Date: Wed, 21 Mar 2018 10:05:53 -0500 [thread overview]
Message-ID: <b3976794-7cb4-912d-d457-762dca65a2f8@redhat.com> (raw)
In-Reply-To: <20180321121940.39426-3-vsementsov@virtuozzo.com>
On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote:
> The helper will be reused for bitmaps namespace.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> nbd/server.c | 41 ++++++++++++++++++++++++++++-------------
> 1 file changed, 28 insertions(+), 13 deletions(-)
>
> +/* Read len bytes and check matching to the pattern.
> + * @match is set to true on empty query for _LIST_ and for query matching the
> + * @pattern. @match is never set to false.
How about:
Read @len bytes, and set @match to true if they match @pattern, or if
@len is 0 and the client is performing _LIST_. @match is never set to
false.
At any rate, the refactoring is sane; and comment touchups are trivial, so
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-21 15:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 12:19 [Qemu-devel] [PATCH for-2.13 0/4] NBD export bitmaps Vladimir Sementsov-Ogievskiy
2018-03-21 12:19 ` [Qemu-devel] [PATCH 1/4] nbd/server: refactor nbd_negotiate_meta_query for several namespaces Vladimir Sementsov-Ogievskiy
2018-03-21 14:56 ` Eric Blake
2018-03-21 17:20 ` Wouter Verhelst
2018-03-22 14:35 ` Vladimir Sementsov-Ogievskiy
2018-03-21 12:19 ` [Qemu-devel] [PATCH 2/4] nbd/server: add nbd_meta_single_query helper Vladimir Sementsov-Ogievskiy
2018-03-21 15:05 ` Eric Blake [this message]
2018-04-13 17:44 ` Vladimir Sementsov-Ogievskiy
2018-04-13 21:06 ` [Qemu-devel] [Qemu-block] " John Snow
2018-04-16 11:22 ` Vladimir Sementsov-Ogievskiy
2018-03-21 12:19 ` [Qemu-devel] [PATCH 3/4] nbd/server: implement dirty bitmap export Vladimir Sementsov-Ogievskiy
2018-03-21 16:57 ` Eric Blake
2018-03-22 15:26 ` Vladimir Sementsov-Ogievskiy
2018-03-28 10:08 ` Vladimir Sementsov-Ogievskiy
2018-03-22 15:32 ` Vladimir Sementsov-Ogievskiy
2018-03-21 12:19 ` [Qemu-devel] [PATCH 4/4] qapi: new qmp command nbd-server-add-bitmap Vladimir Sementsov-Ogievskiy
2018-03-21 17:33 ` Eric Blake
2018-03-22 15:43 ` Vladimir Sementsov-Ogievskiy
2018-03-22 16:19 ` Eric Blake
2018-03-22 16:45 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3976794-7cb4-912d-d457-762dca65a2f8@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).