From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Anthony PERARD" <anthony.perard@citrix.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] Maintainers, please git-am -m
Date: Mon, 25 Feb 2019 10:13:32 -0600 [thread overview]
Message-ID: <b3a486f6-6b72-2950-9fdd-706c2f69c616@redhat.com> (raw)
In-Reply-To: <87d0o24u0s.fsf@dusky.pond.sub.org>
On 2/8/19 1:30 AM, Markus Armbruster wrote:
> Short story: please add
>
> [am]
> messageid = true
>
> to your .gitconfig.
>
> Long story. git-am can add a Message-id: tag. Looks like this:
>
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Acked-by: Alex Bennée <alex.bennee@linaro.org>
> ---> Message-id: 1549268743-18502-1-git-send-email-thuth@redhat.com
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> The Message-id identifies the patch e-mail. It makes finding the review
> thread easier and more reliable. It's also a valid key on Patchew[*].
I find the tag valuable enough in later git searches that I don't mind
feeding my own patches back through the mailing list to add it (patchew
helps with that, of course). But for it to become mandatory, we'd need
to enhance scripts/checkpatch.pl to enforce it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-02-25 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 7:30 [Qemu-devel] Maintainers, please git-am -m Markus Armbruster
2019-02-08 7:45 ` Thomas Huth
2019-02-08 10:31 ` Gerd Hoffmann
2019-02-08 8:57 ` Cornelia Huck
2019-02-08 10:34 ` Gerd Hoffmann
2019-02-08 16:07 ` Philippe Mathieu-Daudé
2019-02-08 16:59 ` Markus Armbruster
2019-02-08 17:18 ` Paolo Bonzini
2019-02-25 16:13 ` Eric Blake [this message]
2019-02-26 7:15 ` Markus Armbruster
2019-02-26 14:14 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a486f6-6b72-2950-9fdd-706c2f69c616@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jcmvbkbc@gmail.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@sifive.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).