From: Thomas Huth <thuth@redhat.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>, eric.auger@redhat.com
Cc: lvivier@redhat.com, mst@redhat.com, cohuck@redhat.com,
qemu-devel@nongnu.org, dgilbert@redhat.com, pasic@linux.ibm.com,
pbonzini@redhat.com
Subject: Re: [PATCH v3 4/4] tests/qtest/virtio-iommu-test: Check bypass config
Date: Mon, 21 Feb 2022 10:11:12 +0100 [thread overview]
Message-ID: <b3b8c372-e0c8-1814-fab4-a6f6f19ff10a@redhat.com> (raw)
In-Reply-To: <20220214124356.872985-5-jean-philippe@linaro.org>
On 14/02/2022 13.43, Jean-Philippe Brucker wrote:
> The bypass config field should be initialized to 1 by default.
>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> tests/qtest/virtio-iommu-test.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qtest/virtio-iommu-test.c b/tests/qtest/virtio-iommu-test.c
> index 47e68388a0..068e7a9e6c 100644
> --- a/tests/qtest/virtio-iommu-test.c
> +++ b/tests/qtest/virtio-iommu-test.c
> @@ -31,11 +31,13 @@ static void pci_config(void *obj, void *data, QGuestAllocator *t_alloc)
> uint64_t input_range_end = qvirtio_config_readq(dev, 16);
> uint32_t domain_range_start = qvirtio_config_readl(dev, 24);
> uint32_t domain_range_end = qvirtio_config_readl(dev, 28);
> + uint8_t bypass = qvirtio_config_readb(dev, 36);
>
> g_assert_cmpint(input_range_start, ==, 0);
> g_assert_cmphex(input_range_end, ==, UINT64_MAX);
> g_assert_cmpint(domain_range_start, ==, 0);
> g_assert_cmpint(domain_range_end, ==, UINT32_MAX);
> + g_assert_cmpint(bypass, ==, 1);
> }
>
> static int read_tail_status(struct virtio_iommu_req_tail *buffer)
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2022-02-21 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 12:43 [PATCH v3 0/4] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG Jean-Philippe Brucker
2022-02-14 12:43 ` [PATCH v3 1/4] linux-headers: update to v5.17-rc1 Jean-Philippe Brucker
2022-02-14 12:43 ` [PATCH v3 2/4] virtio-iommu: Default to bypass during boot Jean-Philippe Brucker
2022-02-14 12:43 ` [PATCH v3 3/4] virtio-iommu: Support bypass domain Jean-Philippe Brucker
2022-02-14 12:43 ` [PATCH v3 4/4] tests/qtest/virtio-iommu-test: Check bypass config Jean-Philippe Brucker
2022-02-21 9:11 ` Thomas Huth [this message]
2022-02-14 17:34 ` [PATCH v3 0/4] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG Cornelia Huck
2022-02-15 9:16 ` Eric Auger
2022-02-15 9:48 ` Jean-Philippe Brucker
2022-02-15 11:58 ` Cornelia Huck
2022-02-15 9:25 ` Eric Auger
2022-02-15 9:49 ` Jean-Philippe Brucker
2022-03-03 11:41 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b8c372-e0c8-1814-fab4-a6f6f19ff10a@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).