From: Alexander Graf <graf@amazon.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: <kvm@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<linux-hyperv@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<adrian@parity.io>, <ardb@kernel.org>, <ben@skyportsystems.com>,
<berrange@redhat.com>, <colmmacc@amazon.com>,
<decui@microsoft.com>, <dwmw@amazon.co.uk>, <ebiggers@kernel.org>,
<ehabkost@redhat.com>, <gregkh@linuxfoundation.org>,
<haiyangz@microsoft.com>, <imammedo@redhat.com>,
<jannh@google.com>, <kys@microsoft.com>, <lersek@redhat.com>,
<linux@dominikbrodowski.net>, <mst@redhat.com>,
<qemu-devel@nongnu.org>, <raduweis@amazon.com>,
<sthemmin@microsoft.com>, <tytso@mit.edu>, <wei.liu@kernel.org>
Subject: Re: [PATCH v4] virt: vmgenid: introduce driver for reinitializing RNG on VM fork
Date: Fri, 25 Feb 2022 16:15:59 +0100 [thread overview]
Message-ID: <b3b9dd9b-c42c-f057-f546-3e390b50479f@amazon.com> (raw)
In-Reply-To: <YhjttNadaaJzVa5X@zx2c4.com>
On 25.02.22 15:54, Jason A. Donenfeld wrote:
> Hi Alex,
>
> Missed this remark before:
>
> On Fri, Feb 25, 2022 at 02:57:38PM +0100, Alexander Graf wrote:
>> Please expose the vmgenid via /sysfs so that user space even remotely
>> has a chance to check if it's been cloned.
> No. Did you read the 0/2 cover letter? I'll quote it for you here:
>
>> As a side note, this series intentionally does _not_ focus on
>> notification of these events to userspace or to other kernel consumers.
>> Since these VM fork detection events first need to hit the RNG, we can
>> later talk about what sorts of notifications or mmap'd counters the RNG
>> should be making accessible to elsewhere. But that's a different sort of
>> project and ties into a lot of more complicated concerns beyond this
>> more basic patchset. So hopefully we can keep the discussion rather
>> focused here to this ACPI business.
> What about that was unclear to you?
>
> Anyway, it's a different thing that will have to be designed and
> considered carefully, and that design doesn't have a whole lot to do
> with this little driver here, except insofar as it could build on top of
> it in one way or another. Yes, it's an important thing to do. No, I'm
> not going to do it in this patch here. If you want to have a discussion
> about that, start a different thread.
I'm not talking about a notification interface - we've gone through
great length on that one in the previous submission. What I'm more
interested in is *any* way for user space to read the current VM Gen ID.
The same way I'm interested to see other device attributes of my system
through sysfs.
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2022-02-25 15:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 13:39 [PATCH v3 0/2] VM fork detection for RNG Jason A. Donenfeld
2022-02-24 13:39 ` [PATCH v3 1/2] random: add mechanism for VM forks to reinitialize crng Jason A. Donenfeld
2022-02-25 11:26 ` Ard Biesheuvel
2022-02-25 11:43 ` Jason A. Donenfeld
2022-02-25 11:44 ` Ard Biesheuvel
2022-02-24 13:39 ` [PATCH v3 2/2] virt: vmgenid: introduce driver for reinitializing RNG on VM fork Jason A. Donenfeld
2022-02-25 10:37 ` Laszlo Ersek
2022-02-25 11:24 ` Ard Biesheuvel
2022-02-25 11:51 ` Michael S. Tsirkin
2022-02-25 12:01 ` Jason A. Donenfeld
2022-02-25 12:00 ` Jason A. Donenfeld
2022-02-25 12:48 ` [PATCH v4] " Jason A. Donenfeld
2022-02-25 12:52 ` Greg KH
2022-02-25 12:53 ` Greg KH
2022-02-25 12:56 ` Jason A. Donenfeld
2022-02-25 15:04 ` Ard Biesheuvel
2022-02-25 13:57 ` Alexander Graf
2022-02-25 14:12 ` Jason A. Donenfeld
2022-02-25 14:18 ` Jason A. Donenfeld
2022-02-25 14:18 ` Alexander Graf
2022-02-25 14:33 ` Jason A. Donenfeld
2022-02-25 15:11 ` Alexander Graf
2022-02-25 15:16 ` Ard Biesheuvel
2022-02-25 15:22 ` Alexander Graf
2022-02-25 15:43 ` Jason A. Donenfeld
2022-02-25 15:57 ` Alexander Graf
2022-02-25 15:34 ` Jason A. Donenfeld
2022-02-25 15:37 ` Alexander Graf
2022-02-25 15:45 ` Jason A. Donenfeld
2022-02-25 14:36 ` Greg KH
2022-02-25 15:31 ` Alexander Graf
2022-02-25 15:36 ` Jason A. Donenfeld
2022-02-25 14:54 ` Jason A. Donenfeld
2022-02-25 15:15 ` Alexander Graf [this message]
2022-02-25 15:28 ` Jason A. Donenfeld
2022-02-25 15:03 ` Ard Biesheuvel
2022-02-25 15:14 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b9dd9b-c42c-f057-f546-3e390b50479f@amazon.com \
--to=graf@amazon.com \
--cc=Jason@zx2c4.com \
--cc=adrian@parity.io \
--cc=ardb@kernel.org \
--cc=ben@skyportsystems.com \
--cc=berrange@redhat.com \
--cc=colmmacc@amazon.com \
--cc=decui@microsoft.com \
--cc=dwmw@amazon.co.uk \
--cc=ebiggers@kernel.org \
--cc=ehabkost@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=imammedo@redhat.com \
--cc=jannh@google.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=lersek@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=raduweis@amazon.com \
--cc=sthemmin@microsoft.com \
--cc=tytso@mit.edu \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).