From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebdT1-0001rA-2g for qemu-devel@nongnu.org; Tue, 16 Jan 2018 21:28:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebdSx-00038V-3K for qemu-devel@nongnu.org; Tue, 16 Jan 2018 21:28:43 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:43370) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebdSw-000384-UR for qemu-devel@nongnu.org; Tue, 16 Jan 2018 21:28:39 -0500 Received: by mail-pl0-f65.google.com with SMTP id f4so6256374plr.10 for ; Tue, 16 Jan 2018 18:28:38 -0800 (PST) From: Fam Zheng References: <20180115170243.24578-1-berrange@redhat.com> <20180115170243.24578-14-berrange@redhat.com> Message-ID: Date: Wed, 17 Jan 2018 10:28:31 +0800 MIME-Version: 1.0 In-Reply-To: <20180115170243.24578-14-berrange@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Qemu-devel] [PATCH v4 13/13] docker: change Fedora images to run with python3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Eric Blake , Markus Armbruster , Eduardo Habkost , Paolo Bonzini On 01/16/2018 01:02 AM, Daniel P. Berrange wrote: > Fedora has switched to Python 3 by default, so it makes sense to use that > for testing QEMU builds, so we get testing of Python 3 compatibility. > > Signed-off-by: Daniel P. Berrange > --- > tests/docker/dockerfiles/fedora.docker | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker > index 4b26c3aded..a22fe16157 100644 > --- a/tests/docker/dockerfiles/fedora.docker > +++ b/tests/docker/dockerfiles/fedora.docker > @@ -1,6 +1,6 @@ > FROM fedora:latest > ENV PACKAGES \ > - ccache gettext git tar PyYAML sparse flex bison python2 bzip2 hostname \ > + ccache gettext git tar PyYAML sparse flex bison python3 bzip2 hostname \ > glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel \ > gcc gcc-c++ clang make perl which bc findutils libaio-devel \ > nettle-devel \ > @@ -12,6 +12,7 @@ ENV PACKAGES \ > mingw64-gtk2 mingw64-gtk3 mingw64-gnutls mingw64-nettle mingw64-libtasn1 \ > mingw64-libjpeg-turbo mingw64-libpng mingw64-curl mingw64-libssh2 \ > mingw64-bzip2 > +ENV QEMU_CONFIGURE_OPTS --python=/usr/bin/python3 > > RUN dnf install -y $PACKAGES > RUN rpm -q $PACKAGES | sort > /packages.txt QAPI changes stands out in the series' diffstat, so: Reviewed-by: Fam Zheng Acked-by: Fam Zheng