From: Thomas Huth <thuth@redhat.com>
To: luoyonggang@gmail.com, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Daniel P . Berrange" <berrange@redhat.com>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-level <qemu-devel@nongnu.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw
Date: Wed, 16 Sep 2020 08:47:31 +0200 [thread overview]
Message-ID: <b3c62fe6-6233-c7d0-e120-074ac976ceb4@redhat.com> (raw)
In-Reply-To: <CAE2XoE_N=XWeg1y74=ohb_p5qiH+rewDtwSGfSwkhHJpA2V06A@mail.gmail.com>
On 15/09/2020 21.17, 罗勇刚(Yonggang Luo) wrote:
> I agree with that, seems QEMU currently are calling ANSI api all the
> time, better not change that,
> so globally define -DUNICODE -D_UNICODE is not a option
I agree, -DUNICODE is currently not an option. I'll go with my patch
("qga/commands-win32: Fix problem with redundant protype declaration")
for the time being, until someone found a nicer solution that works.
Thomas
prev parent reply other threads:[~2020-09-16 6:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 16:33 [PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw Yonggang Luo
2020-09-15 16:41 ` Philippe Mathieu-Daudé
2020-09-15 17:41 ` 罗勇刚(Yonggang Luo)
2020-09-15 17:55 ` Philippe Mathieu-Daudé
2020-09-15 19:17 ` 罗勇刚(Yonggang Luo)
2020-09-16 6:47 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c62fe6-6233-c7d0-e120-074ac976ceb4@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=luoyonggang@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).