From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cm0ts-0007fP-0h for qemu-devel@nongnu.org; Thu, 09 Mar 2017 11:26:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cm0to-0002u8-Tq for qemu-devel@nongnu.org; Thu, 09 Mar 2017 11:26:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49038) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cm0to-0002tq-NI for qemu-devel@nongnu.org; Thu, 09 Mar 2017 11:26:44 -0500 References: <20170309152708.30635-1-dgilbert@redhat.com> <20170309161352.GI2480@work-vm> From: Paolo Bonzini Message-ID: Date: Thu, 9 Mar 2017 17:26:42 +0100 MIME-Version: 1.0 In-Reply-To: <20170309161352.GI2480@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org On 09/03/2017 17:13, Dr. David Alan Gilbert wrote: >>> + * @name: Region name, becomes part of RAMBlock name used in migration stream >>> + * must be unique within any device >>> * @size: size of the region; any subregions beyond this size will be clipped >>> */ >>> void memory_region_init(MemoryRegion *mr, >>> struct Object *owner, >>> const char *name, >>> uint64_t size); >> This one should not be necessary I guess? > Why? It's not static so something else could be calling it for > any use. But why would the name end up in a RAMBlock? Paolo