From: Eric Blake <eblake@redhat.com>
To: "Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
Riku Voipio <riku.voipio@iki.fi>,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable
Date: Fri, 5 Oct 2018 13:19:53 -0500 [thread overview]
Message-ID: <b40dca25-2a3c-2e4b-53ad-8f2f1d13143b@redhat.com> (raw)
In-Reply-To: <2b62d615-615b-a128-9c22-7d37df052abb@redhat.com>
On 10/5/18 1:02 PM, Eric Blake wrote:
> On 10/5/18 12:49 PM, Cleber Rosa wrote:
>
>>>
>>> We could add a git pre-commit hook grep'ing for "^#!\
>>> *(/usr/bin/env|/bin/(b?a)?sh)" in the 1st line and then checking the
>>> file perms.
>>>
>>
>> Good idea. Probably better to send that as a different patch, right?
>
> Yes, separate patch. For that matter, "^#!/" is probably a sufficient
> pattern to catch any file that intends to be run via an interpreter, and
> therefore wants to be executable, rather than limiting to just env and
> specific shells.
Also, many maintainers already have scripts/checkpatch.pl as a git
pre-commit hook, and putting the check in checkpatch.pl means that
patchew would also flag the issue.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-10-05 18:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 16:18 [Qemu-devel] [PATCH 00/10] Trivial fixes and clean ups Cleber Rosa
2018-10-04 16:18 ` [Qemu-devel] [PATCH 01/10] qemu-img.c: comment typo fix Cleber Rosa
2018-10-04 16:48 ` Eric Blake
2018-10-04 16:53 ` Cleber Rosa
2018-10-05 13:31 ` Philippe Mathieu-Daudé
2018-10-05 13:40 ` Peter Maydell
2018-10-04 16:18 ` [Qemu-devel] [PATCH 02/10] tests/tcg/README: fix location for lm32 tests Cleber Rosa
2018-10-05 6:41 ` Thomas Huth
2018-10-05 13:51 ` Alex Bennée
2018-10-25 13:55 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable Cleber Rosa
2018-10-04 16:48 ` Eric Blake
2018-10-05 13:36 ` Philippe Mathieu-Daudé
2018-10-05 17:49 ` Cleber Rosa
2018-10-05 18:02 ` Eric Blake
2018-10-05 18:19 ` Eric Blake [this message]
2018-10-25 13:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 04/10] qemu-iotests: fix filename containing checks Cleber Rosa
2018-10-05 13:38 ` Philippe Mathieu-Daudé
2018-10-25 13:56 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block Cleber Rosa
2018-10-08 19:49 ` [Qemu-devel] [Qemu-block] " John Snow
2018-10-25 13:59 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 06/10] thunk.c: clean up commented out definition Cleber Rosa
2018-10-04 16:24 ` Laurent Vivier
2018-10-04 16:31 ` Cleber Rosa
2018-10-04 16:36 ` Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 07/10] scripts/decodetree.py: remove unused imports Cleber Rosa
2018-10-05 13:39 ` Philippe Mathieu-Daudé
2018-10-25 13:59 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-04 16:18 ` [Qemu-devel] [PATCH 08/10] scripts/decodetree.py: fix reference to attributes Cleber Rosa
2018-10-05 13:40 ` Philippe Mathieu-Daudé
2018-10-04 16:18 ` [Qemu-devel] [PATCH 09/10] scripts/qemu.py: use a more consistent docstring style Cleber Rosa
2018-10-04 16:50 ` Eric Blake
2018-10-04 16:53 ` Cleber Rosa
2018-10-08 19:44 ` [Qemu-devel] [Qemu-block] " John Snow
2018-10-26 15:25 ` Eduardo Habkost
2018-10-04 16:18 ` [Qemu-devel] [PATCH 10/10] scripts/qemu.py: remove trailing quotes on docstring Cleber Rosa
2018-10-05 13:41 ` Philippe Mathieu-Daudé
2018-10-25 14:00 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-10-26 15:27 ` [Qemu-devel] [PATCH 00/10] Trivial fixes and clean ups Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b40dca25-2a3c-2e4b-53ad-8f2f1d13143b@redhat.com \
--to=eblake@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).