From: Max Reitz <mreitz@redhat.com>
To: Connor Kuehl <ckuehl@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, dillaman@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] iotests/231: Update expected deprecation message
Date: Thu, 1 Apr 2021 18:52:40 +0200 [thread overview]
Message-ID: <b4276364-0eee-f244-1146-ee8ac1a01a59@redhat.com> (raw)
In-Reply-To: <20210401155211.2093139-2-ckuehl@redhat.com>
On 01.04.21 17:52, Connor Kuehl wrote:
> The deprecation message changed slightly at some point in the past but
> the expected output wasn't updated along with it; causing it to fail.
> Fix it, so it passes.
>
> Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
> ---
> tests/qemu-iotests/231.out | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Uh, well, you know what, I can’t find any version where there was any
other output. Even back in 66e6a735e97450ac50fcaf40f78600c688534cae,
where this test was introduced, I get this diff.
What’s going on there?
Max
next prev parent reply other threads:[~2021-04-01 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 15:52 [PATCH 0/2] Fix segfault in qemu_rbd_parse_filename Connor Kuehl
2021-04-01 15:52 ` [PATCH 1/2] iotests/231: Update expected deprecation message Connor Kuehl
2021-04-01 16:52 ` Max Reitz [this message]
2021-04-01 17:07 ` Max Reitz
2021-04-01 17:10 ` Connor Kuehl
2021-04-01 15:52 ` [PATCH 2/2] block/rbd: Don't unescape in qemu_rbd_next_tok() Connor Kuehl
2021-04-01 17:24 ` Max Reitz
2021-04-01 18:09 ` Connor Kuehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4276364-0eee-f244-1146-ee8ac1a01a59@redhat.com \
--to=mreitz@redhat.com \
--cc=ckuehl@redhat.com \
--cc=dillaman@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).