Re: [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On 10/27/2017 12:59 PM, no-reply@patchew.org wrote:
> Hi,
> 
> This series failed build test on ppc host. Please find the details below.
> 

> /var/tmp/patchew-tester-tmp-xb4sc6ly/src/nbd/server.c: In function ‘nbd_co_client_start’:
> /var/tmp/patchew-tester-tmp-xb4sc6ly/src/nbd/server.c:819:12: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>          if (ret < 0) {
>             ^
> /var/tmp/patchew-tester-tmp-xb4sc6ly/src/nbd/server.c:647:13: note: ‘ret’ was declared here
>          int ret;
>              ^

Real bug when reporting success on NBD_OPT_STARTTLS.

This should fix it; I'll squash it into the right place in the series.

diff --git i/nbd/server.c w/nbd/server.c
index ea9fe9970f..2b617f3cd1 100644
--- i/nbd/server.c
+++ w/nbd/server.c
@@ -693,6 +693,7 @@ static int nbd_negotiate_options(NBDClient *client,
uint16_t myflags,
                 if (!tioc) {
                     return -EIO;
                 }
+                ret = 0;
                 object_unref(OBJECT(client->ioc));
                 client->ioc = QIO_CHANNEL(tioc);
                 break;

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]