From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: pierrick.bouvier@linaro.org, alex.bennee@linaro.org, philmd@linaro.org
Subject: Re: [PATCH] include/exec: Move TARGET_PAGE_{SIZE,MASK,BITS} to target_page.h
Date: Thu, 6 Mar 2025 18:08:35 -0800 [thread overview]
Message-ID: <b44e107d-3481-4d88-a0da-e7587c69afe0@linaro.org> (raw)
In-Reply-To: <20250306234108.378881-1-richard.henderson@linaro.org>
On 3/6/25 15:41, Richard Henderson wrote:
> diff --git a/page-vary-target.c b/page-vary-target.c
> index 343b4adb95..1b4a9a10be 100644
> --- a/page-vary-target.c
> +++ b/page-vary-target.c
> @@ -37,5 +37,7 @@ void finalize_target_page_bits(void)
> {
> #ifdef TARGET_PAGE_BITS_VARY
> finalize_target_page_bits_common(TARGET_PAGE_BITS_MIN);
> +#else
> + finalize_target_page_bits_common(TARGET_PAGE_BITS);
> #endif
> }
Actually, the ifdef here should be removed.
TARGET_PAGE_BITS_MIN is always correct.
r~
next prev parent reply other threads:[~2025-03-07 2:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 23:41 [PATCH] include/exec: Move TARGET_PAGE_{SIZE, MASK, BITS} to target_page.h Richard Henderson
2025-03-07 2:08 ` Richard Henderson [this message]
2025-03-07 4:18 ` [PATCH] include/exec: Move TARGET_PAGE_{SIZE,MASK,BITS} " Pierrick Bouvier
-- strict thread matches above, loose matches on Subject: below --
2025-03-07 18:56 [PATCH 00/16] accel/tcg: Compile more files once Richard Henderson
2025-03-07 18:56 ` [PATCH] include/exec: Move TARGET_PAGE_{SIZE, MASK, BITS} to target_page.h Richard Henderson
2025-03-07 19:11 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b44e107d-3481-4d88-a0da-e7587c69afe0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).