From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6FIy-0003ea-II for qemu-devel@nongnu.org; Thu, 04 May 2017 07:52:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6FIx-0002gc-RO for qemu-devel@nongnu.org; Thu, 04 May 2017 07:52:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54610) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6FIx-0002gQ-Kh for qemu-devel@nongnu.org; Thu, 04 May 2017 07:52:19 -0400 References: <20170504084135.7488.24715.stgit@PASHA-ISP> <20170504084210.7488.37561.stgit@PASHA-ISP> <000401d2c4c7$6d5b6d50$481247f0$@ru> From: Paolo Bonzini Message-ID: Date: Thu, 4 May 2017 13:52:13 +0200 MIME-Version: 1.0 In-Reply-To: <000401d2c4c7$6d5b6d50$481247f0$@ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , 'Pavel Dovgalyuk' , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, jasowang@redhat.com, quintela@redhat.com, kraxel@redhat.com On 04/05/2017 13:13, Pavel Dovgalyuk wrote: >>> This patch does not allows saving/loading vmstate when >>> replay events queue is not empty. There is no reliable >>> way to save events queue, because it describes internal >>> coroutine state. Therefore saving and loading operations >>> should be deferred to another record/replay step. >> >> Can it actually be non-empty after bdrv_drain_all? > > drain/flush cannot succeed, because started requests are > prisoned in the replay events queue. But that would apply to loading only. Saving should still be always possible. Paolo