From: David Hildenbrand <david@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 06/12] hostmem: drop error variable from host_memory_backend_get_memory()
Date: Fri, 15 Jun 2018 14:45:37 +0200 [thread overview]
Message-ID: <b47a7a83-84da-d239-e52a-d683668e77a8@redhat.com> (raw)
In-Reply-To: <20180615143923.1babac86@redhat.com>
On 15.06.2018 14:39, Igor Mammedov wrote:
> On Fri, 15 Jun 2018 13:24:54 +0200
> David Hildenbrand <david@redhat.com> wrote:
>
>> Unused, so let's remove it.
>>
>> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
> breaks compilation with
>
> hw/mem/nvdimm.c:171:5: error: too many arguments to function ‘host_memory_backend_get_memory’
> return host_memory_backend_get_memory(dimm->hostmem, &error_abort);
>
Looks like some reshuffling of patches was not that healthy. Will fix.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-06-15 12:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 11:24 [Qemu-devel] [PATCH v2 00/12] pc-dimm: next bunch of cleanups David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 01/12] pc-dimm: remove leftover "struct pc_dimms_capacity" David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)* David Hildenbrand
2018-06-15 11:51 ` Igor Mammedov
2018-06-15 11:52 ` David Hildenbrand
2018-06-15 12:31 ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_* David Hildenbrand
2018-06-15 12:33 ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header David Hildenbrand
2018-06-15 12:36 ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 05/12] pc: factor out pc specific dimm checks into pc_memory_pre_plug() David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 06/12] hostmem: drop error variable from host_memory_backend_get_memory() David Hildenbrand
2018-06-15 12:39 ` Igor Mammedov
2018-06-15 12:45 ` David Hildenbrand [this message]
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 07/12] pc-dimm: merge get_(vmstate_)memory_region() David Hildenbrand
2018-06-15 12:45 ` Igor Mammedov
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 08/12] nvdimm: no need to overwrite get_vmstate_memory_region() David Hildenbrand
2018-06-15 12:46 ` Igor Mammedov
2018-06-15 12:50 ` David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 09/12] nvdimm: convert "unarmed" into a static property David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 10/12] nvdimm: convert "label-size" " David Hildenbrand
2018-06-15 12:53 ` Igor Mammedov
2018-06-15 13:30 ` David Hildenbrand
2018-06-15 13:40 ` David Hildenbrand
2018-06-15 11:24 ` [Qemu-devel] [PATCH v2 11/12] nvdimm: make get_memory_region() perform checks and initialization David Hildenbrand
2018-06-15 13:14 ` Igor Mammedov
2018-06-15 11:25 ` [Qemu-devel] [PATCH v2 12/12] pc-dimm: get_memory_region() will not fail after realize David Hildenbrand
2018-06-15 13:19 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47a7a83-84da-d239-e52a-d683668e77a8@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).