* [PATCH 0/2] gitlab: some minor CI tweaks
@ 2021-09-15 12:54 Daniel P. Berrangé
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Daniel P. Berrangé @ 2021-09-15 12:54 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Daniel P. Berrangé, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Willian Rampazzo, Alex Bennée
Addressing a few issues raised by Peter on IRC yesterday
Daniel P. Berrangé (2):
gitlab: skip the check-patch job on the upstream repo
gitlab: fix passing of TEST_TARGETS env to cirrus
.gitlab-ci.d/cirrus.yml | 2 +-
.gitlab-ci.d/cirrus/build.yml | 1 +
.gitlab-ci.d/static_checks.yml | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo
2021-09-15 12:54 [PATCH 0/2] gitlab: some minor CI tweaks Daniel P. Berrangé
@ 2021-09-15 12:54 ` Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
` (2 more replies)
2021-09-15 12:54 ` [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus Daniel P. Berrangé
2021-09-17 11:23 ` [PATCH 0/2] gitlab: some minor CI tweaks Alex Bennée
2 siblings, 3 replies; 10+ messages in thread
From: Daniel P. Berrangé @ 2021-09-15 12:54 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Daniel P. Berrangé, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Willian Rampazzo, Alex Bennée
The check-patch job is intended to be used by contributors or
subsystem maintainers to see if there are style mistakes. The
false positive rate is too high to be used in a gating scenario
so should not run it on the upstream repo ever.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
.gitlab-ci.d/static_checks.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
index 96dbd9e310..902843f8b3 100644
--- a/.gitlab-ci.d/static_checks.yml
+++ b/.gitlab-ci.d/static_checks.yml
@@ -8,7 +8,7 @@ check-patch:
variables:
GIT_DEPTH: 1000
rules:
- - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
+ - if: '$CI_PROJECT_NAMESPACE == "qemu-project"'
when: never
- when: on_success
allow_failure: true
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
@ 2021-09-15 13:25 ` Richard Henderson
2021-09-15 14:11 ` Thomas Huth
2021-09-15 14:59 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 10+ messages in thread
From: Richard Henderson @ 2021-09-15 13:25 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Willian Rampazzo, Thomas Huth, Alex Bennée,
Philippe Mathieu-Daudé, Wainer dos Santos Moschetta
On 9/15/21 5:54 AM, Daniel P. Berrangé wrote:
> The check-patch job is intended to be used by contributors or
> subsystem maintainers to see if there are style mistakes. The
> false positive rate is too high to be used in a gating scenario
> so should not run it on the upstream repo ever.
>
> Signed-off-by: Daniel P. Berrangé<berrange@redhat.com>
> ---
> .gitlab-ci.d/static_checks.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
@ 2021-09-15 14:11 ` Thomas Huth
2021-09-15 14:59 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2021-09-15 14:11 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Willian Rampazzo, Alex Bennée, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta
On 15/09/2021 14.54, Daniel P. Berrangé wrote:
> The check-patch job is intended to be used by contributors or
> subsystem maintainers to see if there are style mistakes. The
> false positive rate is too high to be used in a gating scenario
> so should not run it on the upstream repo ever.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/static_checks.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
> index 96dbd9e310..902843f8b3 100644
> --- a/.gitlab-ci.d/static_checks.yml
> +++ b/.gitlab-ci.d/static_checks.yml
> @@ -8,7 +8,7 @@ check-patch:
> variables:
> GIT_DEPTH: 1000
> rules:
> - - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH'
> + - if: '$CI_PROJECT_NAMESPACE == "qemu-project"'
> when: never
> - when: on_success
> allow_failure: true
>
Acked-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
2021-09-15 14:11 ` Thomas Huth
@ 2021-09-15 14:59 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-15 14:59 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Willian Rampazzo, Thomas Huth, Alex Bennée,
Wainer dos Santos Moschetta
On 9/15/21 2:54 PM, Daniel P. Berrangé wrote:
> The check-patch job is intended to be used by contributors or
> subsystem maintainers to see if there are style mistakes. The
> false positive rate is too high to be used in a gating scenario
> so should not run it on the upstream repo ever.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/static_checks.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus
2021-09-15 12:54 [PATCH 0/2] gitlab: some minor CI tweaks Daniel P. Berrangé
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
@ 2021-09-15 12:54 ` Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
` (2 more replies)
2021-09-17 11:23 ` [PATCH 0/2] gitlab: some minor CI tweaks Alex Bennée
2 siblings, 3 replies; 10+ messages in thread
From: Daniel P. Berrangé @ 2021-09-15 12:54 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Daniel P. Berrangé, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Willian Rampazzo, Alex Bennée
A typo meant the substitution would not work, and the placeholder in the
target file didn't even exist.
The result was that tests were never run on the FreeBSD and macOS jobs,
only a basic build.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
.gitlab-ci.d/cirrus.yml | 2 +-
.gitlab-ci.d/cirrus/build.yml | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
index 675db69622..e7b25e7427 100644
--- a/.gitlab-ci.d/cirrus.yml
+++ b/.gitlab-ci.d/cirrus.yml
@@ -35,7 +35,7 @@
-e "s|[@]PIP3@|$PIP3|g"
-e "s|[@]PYPI_PKGS@|$PYPI_PKGS|g"
-e "s|[@]CONFIGURE_ARGS@|$CONFIGURE_ARGS|g"
- -e "s|[@]TEST_TARGETSS@|$TEST_TARGETSS|g"
+ -e "s|[@]TEST_TARGETS@|$TEST_TARGETS|g"
<.gitlab-ci.d/cirrus/build.yml >.gitlab-ci.d/cirrus/$NAME.yml
- cat .gitlab-ci.d/cirrus/$NAME.yml
- cirrus-run -v --show-build-log always .gitlab-ci.d/cirrus/$NAME.yml
diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml
index 857bdc5536..c555f5d36e 100644
--- a/.gitlab-ci.d/cirrus/build.yml
+++ b/.gitlab-ci.d/cirrus/build.yml
@@ -13,6 +13,7 @@ env:
PYTHON: "@PYTHON@"
MAKE: "@MAKE@"
CONFIGURE_ARGS: "@CONFIGURE_ARGS@"
+ TEST_TARGETS: "@TEST_TARGETS@"
build_task:
install_script:
--
2.31.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus
2021-09-15 12:54 ` [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus Daniel P. Berrangé
@ 2021-09-15 13:25 ` Richard Henderson
2021-09-15 14:10 ` Thomas Huth
2021-09-15 14:35 ` Willian Rampazzo
2 siblings, 0 replies; 10+ messages in thread
From: Richard Henderson @ 2021-09-15 13:25 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Willian Rampazzo, Thomas Huth, Alex Bennée,
Philippe Mathieu-Daudé, Wainer dos Santos Moschetta
On 9/15/21 5:54 AM, Daniel P. Berrangé wrote:
> A typo meant the substitution would not work, and the placeholder in the
> target file didn't even exist.
>
> The result was that tests were never run on the FreeBSD and macOS jobs,
> only a basic build.
>
> Signed-off-by: Daniel P. Berrangé<berrange@redhat.com>
> ---
> .gitlab-ci.d/cirrus.yml | 2 +-
> .gitlab-ci.d/cirrus/build.yml | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus
2021-09-15 12:54 ` [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
@ 2021-09-15 14:10 ` Thomas Huth
2021-09-15 14:35 ` Willian Rampazzo
2 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2021-09-15 14:10 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel
Cc: Willian Rampazzo, Alex Bennée, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta
On 15/09/2021 14.54, Daniel P. Berrangé wrote:
> A typo meant the substitution would not work, and the placeholder in the
> target file didn't even exist.
>
> The result was that tests were never run on the FreeBSD and macOS jobs,
> only a basic build.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/cirrus.yml | 2 +-
> .gitlab-ci.d/cirrus/build.yml | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
> index 675db69622..e7b25e7427 100644
> --- a/.gitlab-ci.d/cirrus.yml
> +++ b/.gitlab-ci.d/cirrus.yml
> @@ -35,7 +35,7 @@
> -e "s|[@]PIP3@|$PIP3|g"
> -e "s|[@]PYPI_PKGS@|$PYPI_PKGS|g"
> -e "s|[@]CONFIGURE_ARGS@|$CONFIGURE_ARGS|g"
> - -e "s|[@]TEST_TARGETSS@|$TEST_TARGETSS|g"
> + -e "s|[@]TEST_TARGETS@|$TEST_TARGETS|g"
Ooops, missed that in the review :-/
Acked-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus
2021-09-15 12:54 ` [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
2021-09-15 14:10 ` Thomas Huth
@ 2021-09-15 14:35 ` Willian Rampazzo
2 siblings, 0 replies; 10+ messages in thread
From: Willian Rampazzo @ 2021-09-15 14:35 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Thomas Huth, Alex Bennée, qemu-devel,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé
On Wed, Sep 15, 2021 at 9:55 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> A typo meant the substitution would not work, and the placeholder in the
> target file didn't even exist.
>
> The result was that tests were never run on the FreeBSD and macOS jobs,
> only a basic build.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/cirrus.yml | 2 +-
> .gitlab-ci.d/cirrus/build.yml | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/2] gitlab: some minor CI tweaks
2021-09-15 12:54 [PATCH 0/2] gitlab: some minor CI tweaks Daniel P. Berrangé
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
2021-09-15 12:54 ` [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus Daniel P. Berrangé
@ 2021-09-17 11:23 ` Alex Bennée
2 siblings, 0 replies; 10+ messages in thread
From: Alex Bennée @ 2021-09-17 11:23 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Willian Rampazzo, Thomas Huth, qemu-devel,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé
Daniel P. Berrangé <berrange@redhat.com> writes:
> Addressing a few issues raised by Peter on IRC yesterday
Queued to testing/next, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-09-17 11:24 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-15 12:54 [PATCH 0/2] gitlab: some minor CI tweaks Daniel P. Berrangé
2021-09-15 12:54 ` [PATCH 1/2] gitlab: skip the check-patch job on the upstream repo Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
2021-09-15 14:11 ` Thomas Huth
2021-09-15 14:59 ` Philippe Mathieu-Daudé
2021-09-15 12:54 ` [PATCH 2/2] gitlab: fix passing of TEST_TARGETS env to cirrus Daniel P. Berrangé
2021-09-15 13:25 ` Richard Henderson
2021-09-15 14:10 ` Thomas Huth
2021-09-15 14:35 ` Willian Rampazzo
2021-09-17 11:23 ` [PATCH 0/2] gitlab: some minor CI tweaks Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).