From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJx5l-000331-Cd for qemu-devel@nongnu.org; Tue, 06 Nov 2018 03:52:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJwxh-0004qY-NG for qemu-devel@nongnu.org; Tue, 06 Nov 2018 03:43:53 -0500 References: <20181105102044.20547-1-david@redhat.com> <20181105102044.20547-2-david@redhat.com> <20181106060306.GB3539@umbus.fritz.box> From: David Hildenbrand Message-ID: Date: Tue, 6 Nov 2018 09:43:36 +0100 MIME-Version: 1.0 In-Reply-To: <20181106060306.GB3539@umbus.fritz.box> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 01/10] pci/pcie: rename hotplug handler callbacks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, "Michael S . Tsirkin" , Igor Mammedov , Marcel Apfelbaum , Alexander Graf , Eduardo Habkost , "Dr . David Alan Gilbert" , Cornelia Huck , Christian Borntraeger , Richard Henderson , qemu-ppc@nongnu.org, qemu-s390x@nongnu.org On 06.11.18 07:03, David Gibson wrote: > On Mon, Nov 05, 2018 at 11:20:35AM +0100, David Hildenbrand wrote: >> The callbacks are also called for cold plugged devices. Drop the "hot" >> to better match the actual callback names. >> >> While at it, also rename pcie_cap_slot_hotplug_common() to >> pcie_cap_slot_check_common(). > > Uh.. this part of the message doesn't appear to be accurate any more. > Indeed, after renaming it 10 times I think I forgot to update the description :) Thanks! >> >> Signed-off-by: David Hildenbrand > > Apart from that, > > Reviewed-by: David Gibson > -- Thanks, David / dhildenb